Skip to content

Commit

Permalink
test: enable ABCI gRPC client in E2E testnets (#5521)
Browse files Browse the repository at this point in the history
Once #5520 lands, we can re-enable gRPC ABCI protocol in the E2E testnets.
  • Loading branch information
erikgrinaker committed Oct 22, 2020
1 parent 6a99b5d commit 9c8252b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
5 changes: 2 additions & 3 deletions test/e2e/generator/generate.go
Expand Up @@ -24,9 +24,8 @@ var (
}

// The following specify randomly chosen values for testnet nodes.
nodeDatabases = uniformChoice{"goleveldb", "cleveldb", "rocksdb", "boltdb", "badgerdb"}
// FIXME disabled grpc due to https://github.com/tendermint/tendermint/issues/5439
nodeABCIProtocols = uniformChoice{"unix", "tcp", "builtin"} // "grpc"
nodeDatabases = uniformChoice{"goleveldb", "cleveldb", "rocksdb", "boltdb", "badgerdb"}
nodeABCIProtocols = uniformChoice{"unix", "tcp", "grpc", "builtin"}
nodePrivvalProtocols = uniformChoice{"file", "unix", "tcp"}
// FIXME disabled v1 due to https://github.com/tendermint/tendermint/issues/5444
// FIXME disabled v2 due to https://github.com/tendermint/tendermint/issues/5513
Expand Down
8 changes: 2 additions & 6 deletions test/e2e/networks/ci.toml
Expand Up @@ -50,9 +50,7 @@ persist_interval = 0
[node.validator03]
seeds = ["seed01"]
database = "badgerdb"
# FIXME Should use grpc, but it has race conditions
# https://github.com/tendermint/tendermint/issues/5439
abci_protocol = "unix"
abci_protocol = "grpc"
privval_protocol = "unix"
persist_interval = 3
retain_blocks = 3
Expand All @@ -72,9 +70,7 @@ start_at = 1005 # Becomes part of the validator set at 1010
seeds = ["seed02"]
database = "cleveldb"
fast_sync = "v0"
# FIXME Should use grpc, but it has race conditions
# https://github.com/tendermint/tendermint/issues/5439
abci_protocol = "tcp"
abci_protocol = "grpc"
privval_protocol = "tcp"
# FIXME The WAL gets corrupted when killed
# https://github.com/tendermint/tendermint/issues/5422
Expand Down

0 comments on commit 9c8252b

Please sign in to comment.