check if deliverTxResCh is still open, return an err otherwise

Fixes #2408
tendermint · Nov 29, 2018 · c85b5d7 · c85b5d7
1 parent 44b769b
commit c85b5d7
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/rpc/core/mempool.go b/rpc/core/mempool.go
@@ -198,7 +198,10 @@ func BroadcastTxCommit(tx types.Tx) (*ctypes.ResultBroadcastTxCommit, error) {
 	// TODO: configurable?
 	var deliverTxTimeout = rpcserver.WriteTimeout / 2
 	select {
-	case deliverTxResMsg := <-deliverTxResCh: // The tx was included in a block.
+	case deliverTxResMsg, ok := <-deliverTxResCh: // The tx was included in a block.
+		if !ok {
+			return nil, errors.New("Error on broadcastTxCommit: expected DeliverTxResult, got nil. Did the Tendermint stop?")
+		}
 		deliverTxRes := deliverTxResMsg.(types.EventDataTx)
 		return &ctypes.ResultBroadcastTxCommit{
 			CheckTx:   *checkTxRes,