Skip to content

Commit

Permalink
config: cors options are arrays of strings, not strings
Browse files Browse the repository at this point in the history
Fixes #2980
  • Loading branch information
melekes committed Dec 10, 2018
1 parent 41eaf0e commit d9f8840
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG_PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ Special thanks to external contributors on this release:
### IMPROVEMENTS:

### BUG FIXES:
- [kv indexer] \#2912 don't ignore key when executing CONTAINS
- [kv indexer] \#2912 don't ignore key when executing CONTAINS
- [config] \#2980 fix cors options formatting
2 changes: 1 addition & 1 deletion config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,7 @@ type InstrumentationConfig struct {
// 0 - unlimited.
MaxOpenConnections int `mapstructure:"max_open_connections"`

// Tendermint instrumentation namespace.
// Instrumentation namespace.
Namespace string `mapstructure:"namespace"`
}

Expand Down
6 changes: 3 additions & 3 deletions config/toml.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,13 @@ laddr = "{{ .RPC.ListenAddress }}"
# A list of origins a cross-domain request can be executed from
# Default value '[]' disables cors support
# Use '["*"]' to allow any origin
cors_allowed_origins = "{{ .RPC.CORSAllowedOrigins }}"
cors_allowed_origins = {{ .RPC.CORSAllowedOrigins }}
# A list of methods the client is allowed to use with cross-domain requests
cors_allowed_methods = "{{ .RPC.CORSAllowedMethods }}"
cors_allowed_methods = {{ .RPC.CORSAllowedMethods }}
# A list of non simple headers the client is allowed to use with cross-domain requests
cors_allowed_headers = "{{ .RPC.CORSAllowedHeaders }}"
cors_allowed_headers = {{ .RPC.CORSAllowedHeaders }}
# TCP or UNIX socket address for the gRPC server to listen on
# NOTE: This server only supports /broadcast_tx_commit
Expand Down

0 comments on commit d9f8840

Please sign in to comment.