add back link to issue #1622 in documentation

tendermint · Oct 12, 2018 · ec25edd · ec25edd
1 parent b741c8b
commit ec25edd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/docs/spec/blockchain/encoding.md b/docs/spec/blockchain/encoding.md
@@ -316,4 +316,5 @@ type CanonicalVote struct {
 }
 ```
 The field ordering and the fixed sized encoding for the first three fields is optimized to ease parsing of SignBytes 
-in HSMs. It creates fixed offsets for relevant fields that need to be read in this context.
+in HSMs. It creates fixed offsets for relevant fields that need to be read in this context. 
+See [#1622](https://github.com/tendermint/tendermint/issues/1622) for more details. 
diff --git a/types/vote_test.go b/types/vote_test.go
@@ -63,7 +63,7 @@ func TestVoteSignableTestVectors(t *testing.T) {
 	}{
 		{
 			CanonicalizeVote("", &Vote{}),
-			// XXX: Here Height and Round are skipped. This probably will be cumbersome to to parse in the HSM:
+			// NOTE: Height and Round are skipped here. This case needs to be considered while parsing.
 			[]byte{0xb, 0x2a, 0x9, 0x9, 0x0, 0x9, 0x6e, 0x88, 0xf1, 0xff, 0xff, 0xff},
 		},
 		// with proper (fixed size) height and round: