Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABCI: ResponseCheckTx and ResponseDeliverTx expects single-coin Fee #1997

Closed
AdityaSripal opened this issue Jul 17, 2018 · 2 comments
Closed
Labels
C:abci Component: Application Blockchain Interface S:proposal Status: Proposal
Milestone

Comments

@AdityaSripal
Copy link
Contributor

ABCI API Change Request:

Currently the ResponseCheckTx and ResponseDeliverTx structs both have a Fee attribute of type common.KI64Pair. This assumes that a single coin is used for the transaction fee which is an assumption not shared by the Cosmos-SDK as seen in StdFee and FeeCollectionKeeper in x/auth module which expects sdk.Coins for the FeeAmount.

Changing the Fee attribute in the ABCI response to []common.KI64Pair will allow the response and the corresponding sdk.Result to represent multicoin fees. This will make the ABCI more extensible and in-line with the cosmos SDK.

@AdityaSripal AdityaSripal added C:abci Component: Application Blockchain Interface S:proposal Status: Proposal prelaunch labels Jul 17, 2018
@AdityaSripal AdityaSripal changed the title ResponseCheckTx and ResponseDeliverTx expects single-coin Fee ABCI: ResponseCheckTx and ResponseDeliverTx expects single-coin Fee Jul 17, 2018
@AdityaSripal
Copy link
Contributor Author

From discussion with @sunnya97:

Rather than include anything about FeeCoins into the response, we create a Priority uint that could be used in the future to order transactions from mempool

It's upto the application to calculate the Priority

@melekes melekes removed the prelaunch label Jul 18, 2018
@xla xla added this to the launch milestone Jul 18, 2018
@ebuchman
Copy link
Contributor

Yeh! Closing for #1861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:abci Component: Application Blockchain Interface S:proposal Status: Proposal
Projects
None yet
Development

No branches or pull requests

4 participants