Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in Fee structure in Result and auth.StdTx #1701

Closed
4 tasks
AdityaSripal opened this issue Jul 16, 2018 · 4 comments
Closed
4 tasks

Difference in Fee structure in Result and auth.StdTx #1701

AdityaSripal opened this issue Jul 16, 2018 · 4 comments
Labels

Comments

@AdityaSripal
Copy link
Member

Summary of Bug

auth.StdTx allows users to pass in sdk.Coins into StdFee. However the sdk.Result struct seems to expect using a single coin for the fee.

// Tx fee amount and denom.
FeeAmount int64
FeeDenom  string

Suggested Fix

Allow result to store multicoin fee

// Tx fee amount and denom.
FeeAmount []int64
FeeDenom  []string

Construct list such that amount list indices are correctly matched with denom list indices. May also want to sort the denoms in the same way that sdk.Coins does the sort.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ValarDragon
Copy link
Contributor

ValarDragon commented Jul 17, 2018

Why should it expect:

FeeAmount []int64
FeeDenom  []string

and not

FeeCoins sdk.Coins

@AdityaSripal
Copy link
Member Author

Yea, that works better. Just followed the initial model.

@AdityaSripal
Copy link
Member Author

Dependent on: tendermint/tendermint#1997

@AdityaSripal AdityaSripal added the S:blocked Status: Blocked label Jul 17, 2018
@AdityaSripal
Copy link
Member Author

Should be fixed in tendermint/tendermint#1861

chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants