Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitepaper on blog #2

Closed
jaekwon opened this issue Nov 6, 2014 · 0 comments
Closed

Whitepaper on blog #2

jaekwon opened this issue Nov 6, 2014 · 0 comments
Labels
C:docs Component: Documentation

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Nov 6, 2014

Remove link to outdated PDF whitepaper, move contents to tendermint.com/blog.
Update "whitepage".
@jaekwon jaekwon added this to the Launch milestone Nov 6, 2014
@jaekwon jaekwon added the C:docs Component: Documentation label Nov 6, 2014
@jaekwon jaekwon closed this as completed Mar 20, 2015
melekes added a commit to melekes/tendermint that referenced this issue Dec 20, 2016
@melekes
fix 2 errors when running p2p tests more than once
4117e60 
Error tendermint#1:

```
Error response from daemon: network with name local_testnet already exists
```

Fixed by stopping and removing local_testnet containers and removing
the network

Error tendermint#2:

```
docker: Error response from daemon: Conflict. The name "/test_container_basic" is already in use by container a7cd15d479a964675e7f259de4ed852e7dfef85b447514728f437cd0b980a709. You have to remove (or rename) that container to beable to reuse that name..
```

Fixed by adding `--rm` flag.
ebuchman pushed a commit that referenced this issue Dec 23, 2016
@melekes @ebuchman
fix 2 errors when running p2p tests more than once
57f3592 
Error #1:

```
Error response from daemon: network with name local_testnet already exists
```

Fixed by stopping and removing local_testnet containers and removing
the network

Error #2:

```
docker: Error response from daemon: Conflict. The name "/test_container_basic" is already in use by container a7cd15d479a964675e7f259de4ed852e7dfef85b447514728f437cd0b980a709. You have to remove (or rename) that container to beable to reuse that name..
```

Fixed by adding `--rm` flag.
ebuchman pushed a commit that referenced this issue Apr 21, 2017
@jaekwon
Merge pull request #2 from tendermint/develop
4baf007 
make some params configurable
@greg-szabo greg-szabo mentioned this issue Jun 20, 2017
Closed
odeke-em added a commit that referenced this issue Nov 15, 2017
@odeke-em
p2p: peer should respect errors from SetDeadline
f8959d5 
Noticed while auditing the code that we aren't respecting
(*net.Conn) SetDeadline errors which return after
a connection has been killed and is simultaneously
being used.

For example given program, without SetDeadline error checks
```go
package main

import (
  "log"
  "net"
  "time"
)

func main() {
  conn, err := net.Dial("tcp", "tendermint.com:443")
  if err != nil {
    log.Fatal(err)
  }
  go func() {
    <-time.After(400 * time.Millisecond)
    conn.Close()
  }()
  for i := 0; i < 5; i++ {
    if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil {
      log.Fatalf("set deadline #%d, err: %v", i, err)
    }
    log.Printf("Successfully set deadline #%d", i)
    <-time.After(150 * time.Millisecond)
  }
}
```

erraneously gives
```shell
2017/11/14 17:46:28 Successfully set deadline #0
2017/11/14 17:46:29 Successfully set deadline #1
2017/11/14 17:46:29 Successfully set deadline #2
2017/11/14 17:46:29 Successfully set deadline #3
2017/11/14 17:46:29 Successfully set deadline #4
```

However, if we properly fix it to respect that error with
```diff
--- wild.go 2017-11-14 17:44:38.000000000 -0700
+++ main.go 2017-11-14 17:45:40.000000000 -0700
@@ -16,7 +16,9 @@
    conn.Close()
  }()
  for i := 0; i < 5; i++ {
-   conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second)))
+   if err := conn.SetDeadline(time.Now().Add(time.Duration(10 *
time.Second))); err != nil {
+     log.Fatalf("set deadline #%d, err: %v", i, err)
+   }
    log.Printf("Successfully set deadline #%d", i)
    <-time.After(150 * time.Millisecond)
  }
```

properly catches any problems and gives
```shell
$ go run main.go
2017/11/14 17:43:44 Successfully set deadline #0
2017/11/14 17:43:45 Successfully set deadline #1
2017/11/14 17:43:45 Successfully set deadline #2
2017/11/14 17:43:45 set deadline #3, err: set tcp 10.182.253.51:57395:
use of closed network connection
exit status 1
```
odeke-em added a commit that referenced this issue Nov 15, 2017
@odeke-em
p2p: peer should respect errors from SetDeadline
7b0fa6c 
Noticed while auditing the code that we aren't respecting
(*net.Conn) SetDeadline errors which return after
a connection has been killed and is simultaneously
being used.

For example given program, without SetDeadline error checks
```go
package main

import (
  "log"
  "net"
  "time"
)

func main() {
  conn, err := net.Dial("tcp", "tendermint.com:443")
  if err != nil {
    log.Fatal(err)
  }
  go func() {
    <-time.After(400 * time.Millisecond)
    conn.Close()
  }()
  for i := 0; i < 5; i++ {
    if err := conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second))); err != nil {
      log.Fatalf("set deadline #%d, err: %v", i, err)
    }
    log.Printf("Successfully set deadline #%d", i)
    <-time.After(150 * time.Millisecond)
  }
}
```

erraneously gives
```shell
2017/11/14 17:46:28 Successfully set deadline #0
2017/11/14 17:46:29 Successfully set deadline #1
2017/11/14 17:46:29 Successfully set deadline #2
2017/11/14 17:46:29 Successfully set deadline #3
2017/11/14 17:46:29 Successfully set deadline #4
```

However, if we properly fix it to respect that error with
```diff
--- wild.go 2017-11-14 17:44:38.000000000 -0700
+++ main.go 2017-11-14 17:45:40.000000000 -0700
@@ -16,7 +16,9 @@
    conn.Close()
  }()
  for i := 0; i < 5; i++ {
-   conn.SetDeadline(time.Now().Add(time.Duration(10 * time.Second)))
+   if err := conn.SetDeadline(time.Now().Add(time.Duration(10 *
time.Second))); err != nil {
+     log.Fatalf("set deadline #%d, err: %v", i, err)
+   }
    log.Printf("Successfully set deadline #%d", i)
    <-time.After(150 * time.Millisecond)
  }
```

properly catches any problems and gives
```shell
$ go run main.go
2017/11/14 17:43:44 Successfully set deadline #0
2017/11/14 17:43:45 Successfully set deadline #1
2017/11/14 17:43:45 Successfully set deadline #2
2017/11/14 17:43:45 set deadline #3, err: set tcp 10.182.253.51:57395:
use of closed network connection
exit status 1
```
ebuchman pushed a commit that referenced this issue Jun 20, 2018
@jaekwon
Merge pull request #2 from tendermint/cli
8b9df7d 
refactor dummy; flush tmsp reqs
ebuchman pushed a commit that referenced this issue Jun 20, 2018
@jaekwon
Merge pull request #2 from alessio/master
48b17de 
Add LICENSE file
ebuchman added a commit that referenced this issue Jun 20, 2018
@ebuchman
Merge pull request #2 from tendermint/make_and_circle
f7c8729 
Makefile and circle.yml
zramsay pushed a commit that referenced this issue Jul 10, 2018
@greg-szabo
Merge pull request #2 from tendermint/refactor
86d999a 
Refactor branch to master
zramsay pushed a commit that referenced this issue Jul 10, 2018
@greg-szabo
Workaround for gaia packaging until issue #2 is resolved
a607ff5
zramsay pushed a commit that referenced this issue Jul 10, 2018
@greg-szabo
Fix for workaround #2
f46d044
ebuchman added a commit that referenced this issue Aug 5, 2018
@ebuchman
Merge pull request #1815 from tendermint/jae/literefactor4
06a157a 
ValidatorSet change delayed by 1 block, and lite refactor (#2)
vaibhavchellani pushed a commit to vaibhavchellani/tendermint that referenced this issue Sep 27, 2018
@jdkanani
Merge pull request tendermint#2 from jdkanani/header-tx
5d283f1 
log vote
kostko referenced this issue in oasisprotocol/tendermint Nov 2, 2018
@kostko
Merge pull request #2 from oasislabs/kostko/fix/evidence-iter-leak
3c900ae 
evidence: Fix iterator leak
@jaekwon jaekwon mentioned this issue Jan 19, 2019
Merged
enlight referenced this issue in loomnetwork/tendermint Mar 5, 2019
@mattkanwisher
Merge pull request #2 from mattkanwisher/mempool-dump-tweaks
48dc265 
Add mempool_txs RPC endpoint that provides extra info about the mempool
@tessr tessr mentioned this issue Jan 4, 2021
Closed
7 tasks
@tessr tessr mentioned this issue Jul 1, 2021
Merged
0xprincess pushed a commit to 0xprincess/tendermint that referenced this issue Jul 29, 2022
attempt to dirty patch duplicate id issue tendermint#2
1b2aeec
faddat pushed a commit to faddat/tendermint that referenced this issue Nov 23, 2022
@erikgrinaker
batch: return errors for all operations (tendermint#96)
442ebe1 
Modify batch `Set`, `Delete`, and `Close` to return errors. The main error condition currently is using closed batches, but future ones include databases which implement batches as transactions (e.g. BadgerDB) and rejecting empty keys (tendermint#2).
faddat pushed a commit to faddat/tendermint that referenced this issue Nov 23, 2022
@erikgrinaker
reject nil/empty keys and nil values (tendermint#99)
7b7076b 
Fixes tendermint#2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:docs Component: Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaekwon