libs/autofile: bring back loops

[ebuchman]

Trying to understand why #2259 is happening.

Looks like could be due to the changes in #2135, where we may have accidentally removed these loops.

• Updated all relevant documentation in docs
• Updated all code comments where relevant
• Wrote tests
• Updated CHANGELOG_PENDING.md

[ebuchman]

Seems to solve the issue from local manual testing.

[codecov-io]

Codecov Report

Merging #2261 into master will increase coverage by 0.17%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##           master    #2261      +/-   ##
==========================================
+ Coverage   62.48%   62.65%   +0.17%     
==========================================
  Files         216      216              
  Lines       17296    17369      +73     
==========================================
+ Hits        10807    10883      +76     
+ Misses       5605     5601       -4     
- Partials      884      885       +1

Impacted Files	Coverage Δ
libs/autofile/group.go	66.75% <0%> (-0.18%)	⬇️
libs/autofile/autofile.go	69.69% <66.66%> (+0.46%)	⬆️
rpc/grpc/api.go	81.81% <0%> (-7.08%)	⬇️
types/validator.go	74% <0%> (-4.13%)	⬇️
rpc/client/httpclient.go	68.78% <0%> (-0.98%)	⬇️
blockchain/reactor.go	39.1% <0%> (-0.34%)	⬇️
p2p/peer.go	57.95% <0%> (ø)	⬆️
consensus/state.go	77.66% <0%> (+0.24%)	⬆️
blockchain/pool.go	66.43% <0%> (+0.69%)	⬆️
config/config.go	83.58% <0%> (+1.77%)	⬆️
... and 2 more

[ValarDragon]

Should we have autofile rotation tests to cover this case?

[melekes]

@bradyjoestar wrote two tests which check rotation here #2244