Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to tm v0.23.1 #2126

Merged
merged 1 commit into from
Aug 23, 2018
Merged

update to tm v0.23.1 #2126

merged 1 commit into from
Aug 23, 2018

Conversation

ebuchman
Copy link
Member

  • fixes unbounded WAL growth

Ref: tendermint/tendermint#2259

Tendermint PR: tendermint/tendermint#2261

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 22, 2018

Codecov Report

Merging #2126 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2126   +/-   ##
=======================================
  Coverage   63.76%   63.76%           
=======================================
  Files         113      113           
  Lines        6671     6671           
=======================================
  Hits         4254     4254           
  Misses       2131     2131           
  Partials      286      286

- fixes unbounded WAL growth
Copy link
Member

@zmanian zmanian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified by multiple users on gaia-8001 that cs.wal stabilizes ~1gb

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ebuchman ebuchman merged commit 1c38c70 into master Aug 23, 2018
@ebuchman ebuchman deleted the bucky/fix-wal branch August 23, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants