Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeInfoOther fix #2433

Closed
ebuchman opened this issue Sep 19, 2018 · 1 comment
Closed

NodeInfoOther fix #2433

ebuchman opened this issue Sep 19, 2018 · 1 comment
Labels
C:p2p Component: P2P pkg
Milestone
Wishlist

Comments

@ebuchman
Copy link
Contributor

Looking at https://github.com/tendermint/tendermint/pull/2426/files#diff-f2fefc7a06ea0d1e0a910196901e50aaR86

  • other.AminoVersion is in there twice
  • .String() method is missing RPCAddress
  • we don't set RPCAddress when we create the NodeInfoOther in node.go
@ebuchman ebuchman added the C:p2p Component: P2P pkg label Sep 19, 2018
@ebuchman ebuchman added this to the v1.0 milestone Sep 19, 2018
@ebuchman ebuchman mentioned this issue Sep 19, 2018
Merged
@melekes
Copy link
Contributor

melekes commented Sep 19, 2018

Oh, thanks for spotting this! It looks like we will need at least 2 reviews going forward before merging.

melekes added a commit that referenced this issue Sep 19, 2018
@melekes
add missing RPCAddress to NodeInfoOther.String() func
b9753fb 
- remove second AminoVersion from
https://github.com/tendermint/tendermint/pull/2426/files#diff-f2fefc7a06ea0d1e0a910196901e50aaR86

Refs #2433
@melekes melekes mentioned this issue Sep 19, 2018
Merged
4 tasks
xla pushed a commit that referenced this issue Sep 19, 2018
@melekes @xla
p2p: add RPCAddress to NodeInfoOther.String() (#2442)
aa5495f 
- remove second AminoVersion from
https://github.com/tendermint/tendermint/pull/2426/files#diff-f2fefc7a06ea0d1e0a910196901e50aaR86

Refs #2433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:p2p Component: P2P pkg
Projects
None yet
Milestone
Wishlist
Development

No branches or pull requests
2 participants
@melekes @ebuchman