Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

mempool: Disable WAL by default #2490

Merged
merged 1 commit into from Sep 28, 2018

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Sep 26, 2018

This should reduce file IO and disk space. For those, who want better guarantees, a note in https://tendermint.com/docs/tendermint-core/running-in-production.html is left of how to enable mempool WAL. In the future, we may want to provide better support and tooling for the mempool WAL recover procedure.

Not sure the measurements below are correct, but that's better than having no pictures 馃槂 These were taken using iostat -yd 5 while tendermint (kvstore) & tm-bench were running in parallel inside my virtual box.

chart
chart 1

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@codecov-io
Copy link

Codecov Report

Merging #2490 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2490      +/-   ##
===========================================
+ Coverage     61.4%   61.49%   +0.08%     
===========================================
  Files          197      197              
  Lines        16432    16407      -25     
===========================================
- Hits         10090    10089       -1     
+ Misses        5507     5487      -20     
+ Partials       835      831       -4
Impacted Files Coverage 螖
config/config.go 82.67% <100%> (酶) 猬嗭笍
libs/db/remotedb/remotedb.go 36.84% <0%> (-4.69%) 猬囷笍
consensus/reactor.go 73.38% <0%> (+0.77%) 猬嗭笍
lite/dbprovider.go 59.18% <0%> (+3.02%) 猬嗭笍

@melekes melekes self-assigned this Sep 26, 2018
@xla xla changed the title disable mempool WAL by default mempool: Disable WAL by default Sep 26, 2018
@xla xla added this to the launch milestone Sep 26, 2018
@xla xla added C:mempool Component: Mempool T:enhancement Type: Enhancement labels Sep 26, 2018
@xla xla added this to Ongoing in Launch Sep 26, 2018
@ebuchman ebuchman merged commit 47bc15c into develop Sep 28, 2018
Launch automation moved this from Ongoing to Done Sep 28, 2018
@ebuchman ebuchman deleted the anton/disable-mempool-wal-by-default branch September 28, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:mempool Component: Mempool T:enhancement Type: Enhancement
Projects
No open projects
Launch
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants