Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libs/autofile: panic when trying to checkHeadSizeLimit #2703

Closed
melekes opened this issue Oct 25, 2018 · 7 comments
Closed

libs/autofile: panic when trying to checkHeadSizeLimit #2703

melekes opened this issue Oct 25, 2018 · 7 comments
Labels
C:libs Component: Library T:bug Type Bug (Confirmed)

Comments

@melekes
Copy link
Contributor

melekes commented Oct 25, 2018

Okt 09 12:50:12 ip-172-31-12-75.us-east-2.compute.internal thorchaind[2387]: github.com/thorchain/THORChain/vendor/github.com/tendermint/tendermint/libs/autofile.(*Group).checkHeadSizeLimit(0xc4207975e0)
Okt 09 12:50:12 ip-172-31-12-75.us-east-2.compute.internal thorchaind[2387]: /Users/philipstanislaus/go/src/github.com/thorchain/THORChain/vendor/github.com/tendermint/tendermint/libs/autofile/group.go:225 +0xa9
Okt 09 12:50:12 ip-172-31-12-75.us-east-2.compute.internal thorchaind[2387]: github.com/thorchain/THORChain/vendor/github.com/tendermint/tendermint/libs/autofile.(*Group).processTicks(0xc4207975e0)
Okt 09 12:50:12 ip-172-31-12-75.us-east-2.compute.internal thorchaind[2387]: /Users/philipstanislaus/go/src/github.com/thorchain/THORChain/vendor/github.com/tendermint/tendermint/libs/autofile/group.go:207 +0x2d
Okt 09 12:50:12 ip-172-31-12-75.us-east-2.compute.internal thorchaind[2387]: created by github.com/thorchain/THORChain/vendor/github.com/tendermint/tendermint/libs/autofile.(*Group).OnStart
Okt 09 12:50:12 ip-172-31-12-75.us-east-2.compute.internal thorchaind[2387]: /Users/philipstanislaus/go/src/github.com/thorchain/THORChain/vendor/github.com/tendermint/tendermint/libs/autofile/group.go:105 +0x3f

Refs #2392 (comment)

@melekes melekes added C:libs Component: Library T:bug Type Bug (Confirmed) labels Oct 25, 2018
@melekes
Copy link
Contributor Author

melekes commented Oct 25, 2018

@philipstanislaus I can't find the error message itself, only the stack trace. Do you remember what was the error or maybe you still have some logs (I can't find the above panic in any of the log files you've provided)?

@ebuchman ebuchman added this to Planned in current iteration via automation Oct 29, 2018
@philipstanislaus
Copy link

@melekes here is the complete log: https://s3.us-east-2.amazonaws.com/tendermint-testnet-issues/2018-10-09_testnet_disconnects_under_load/log-node0.txt

The error is on line 935359 of that file. Thanks!

@melekes
Copy link
Contributor Author

melekes commented Nov 6, 2018

There're a few lines missing (lines which contain the error message)

Okt 09 12:50:04 ip-172-31-12-75.us-east-2.compute.internal thorchaind[2387]: 02650070EE17ABA57300AB40729FCD8494C3199D (183 bytes)
Okt 09 12:50:12 ip-172-31-12-75.us-east-2.compute.internal thorchaind[2387]: github.com/thorchain/THORChain/vendor/github.com/tendermint/tendermint/libs/autofile.(*Group).ch
eckHeadSizeLimit(0xc4207975e0)

Example panic: https://gobyexample.com/panic

melekes added a commit that referenced this issue Nov 6, 2018
It's OK if the head will grow a little bit bigger, but we'll avoid
panic.

Refs #2703
@melekes
Copy link
Contributor Author

melekes commented Nov 6, 2018

I think #2764 is the best thing we can do until we know the exact reason.

@melekes melekes closed this as completed Nov 6, 2018
current iteration automation moved this from Planned to Done Nov 6, 2018
@melekes
Copy link
Contributor Author

melekes commented Nov 6, 2018

@philipstanislaus if you manage to find the error message, please comment on this issue.

@ebuchman
Copy link
Contributor

ebuchman commented Nov 7, 2018

Hmm weird that we can't see the top of the panic here. Are you using a defer/recover somewhere and not printing the full stack trace?

melekes added a commit that referenced this issue Nov 9, 2018
It's OK if the head will grow a little bit bigger, but we'll avoid
panic.

Refs #2703
melekes added a commit that referenced this issue Nov 9, 2018
It's OK if the head will grow a little bit bigger, but we'll avoid
panic.

Refs #2703
@philipstanislaus
Copy link

philipstanislaus commented Nov 10, 2018

@ebuchman the reason is log rate limiting here. I think we are not going to find out what happened here – I will run the same load with the same configuration on the upgraded testnet without rate limited logs and comment here if I get similar results again, as @melekes suggested. Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:libs Component: Library T:bug Type Bug (Confirmed)
Projects
No open projects
Development

No branches or pull requests

3 participants