Fix 2457 #2731
Merged
Fix 2457 #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
melekes
reviewed
Oct 30, 2018
| } | ||
| } | ||
| } | ||
|
|
||
| /* | ||
| // NOTE: This is too hard to test without | ||
| // an easy way to add test peer to switch | ||
| // or without significant refactoring of the module. | ||
| // Alternatively we could actually dial a TCP conn but | ||
| // that seems extreme. | ||
| func TestBadBlockStopsPeer(t *testing.T) { |
There was a problem hiding this comment.
these tests remind me of our consensus tests - hard to read, hard to modify, hard to debug
There was a problem hiding this comment.
Agree, will have to do for now. In future we'll need to restructure the reactors for better testing.
Codecov Report
@@ Coverage Diff @@
## develop #2731 +/- ##
===========================================
+ Coverage 62.19% 62.75% +0.55%
===========================================
Files 212 212
Lines 17362 17388 +26
===========================================
+ Hits 10799 10911 +112
+ Misses 5654 5561 -93
- Partials 909 916 +7
|
danil-lashin
pushed a commit
to danil-lashin/tendermint
that referenced
this pull request
Nov 27, 2018
* develop: types: Emit tags from BeginBlock/EndBlock (tendermint#2747) Fix fast sync stack with wrong block tendermint#2457 (tendermint#2731) It's better read from genDoc than from state.validators when appHeight==0 in replay (tendermint#2893) update encoding spec (tendermint#2903) return back initially allowed level if we encounter allowed key (tendermint#2889) Handling integer IDs in JSON-RPC requests -- fixes tendermint#2366 (tendermint#2811) # Conflicts: # blockchain/reactor_test.go # blockchain/store_test.go # node/node_test.go # types/events.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2621
ref #2457