Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus client_golang dependency is out of date #2798

Closed
ackratos opened this issue Nov 10, 2018 · 2 comments
Closed

prometheus client_golang dependency is out of date #2798

ackratos opened this issue Nov 10, 2018 · 2 comments

Comments

@ackratos
Copy link
Contributor

ackratos commented Nov 10, 2018

our tendermint project depends on https://github.com/deathowl/go-metrics-prometheus (another one depends on go-metrics rather than go-kit to generate metrics) which relies on latest prometheus client_golang https://github.com/prometheus/client_golang. This caused conflict with tendermint dependency.

As the comment in Gopkg.toml file looks wrong, we should remove client_golang constraint.

# Haven't made a release since 2016.
[[constraint]]
  name = "github.com/prometheus/client_golang"
  revision = "ae27198cdd90bf12cd134ad79d1366a6cf49f632"

Tendermint version (use tendermint version or git rev-parse --verify HEAD if installed from source):
1944d85

ABCI app (name for built-in, URL for self-written if it's publicly available):

Environment:

  • OS (e.g. from /etc/os-release):
  • Install tools:
  • Others:

What happened:

What you expected to happen:

Have you tried the latest version: yes/no

How to reproduce it (as minimally and precisely as possible):

Logs (paste a small part showing an error (< 10 lines) or link a pastebin, gist, etc. containing more of the log file):

Config (you can paste only the changes you've made):

node command runtime flags:

/dump_consensus_state output for consensus bugs

Anything else we need to know:

ackratos added a commit to ackratos/tendermint that referenced this issue Nov 10, 2018
@ackratos
Copy link
Contributor Author

PR #2799 is raised for fixing this issue

ackratos added a commit to ackratos/tendermint that referenced this issue Nov 10, 2018
@ackratos ackratos changed the title client_golang dependency is out of date prometheus client_golang dependency is out of date Nov 10, 2018
hleb-albau added a commit to hleb-albau/tendermint that referenced this issue Nov 10, 2018
hleb-albau added a commit to hleb-albau/tendermint that referenced this issue Nov 10, 2018
hleb-albau added a commit to hleb-albau/tendermint that referenced this issue Nov 11, 2018
-- fix review comments
hleb-albau added a commit to hleb-albau/tendermint that referenced this issue Nov 11, 2018
-- fix review comments
hleb-albau added a commit to hleb-albau/tendermint that referenced this issue Nov 11, 2018
hleb-albau added a commit to hleb-albau/tendermint that referenced this issue Nov 11, 2018
hleb-albau added a commit to hleb-albau/tendermint that referenced this issue Nov 11, 2018
hleb-albau added a commit to hleb-albau/tendermint that referenced this issue Nov 13, 2018
melekes added a commit that referenced this issue Nov 15, 2018
because
- they are locked in .lock file already
- individual dependencies can be updated with `dep ensure -update XXX`
- review process (and ^^^) should help us prevent accidental updates

Closes #2798
ebuchman pushed a commit that referenced this issue Nov 15, 2018
because
- they are locked in .lock file already
- individual dependencies can be updated with `dep ensure -update XXX`
- review process (and ^^^) should help us prevent accidental updates

Closes #2798
@melekes
Copy link
Contributor

melekes commented Nov 16, 2018

PR with a fix/feature was merged to develop. Will be shipped with 0.26.2 (check the changelog).

@melekes melekes closed this as completed Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants