do not pin deps to exact versions #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because - they are locked in .lock file already - individual dependencies can be updated with `dep ensure -update XXX` - review process (and ^^^) should help us prevent accidental updates Closes #2798
4 tasks
Codecov Report
@@ Coverage Diff @@
## develop #2844 +/- ##
===========================================
+ Coverage 62.23% 62.41% +0.18%
===========================================
Files 212 212
Lines 17255 17224 -31
===========================================
+ Hits 10738 10750 +12
+ Misses 5614 5572 -42
+ Partials 903 902 -1
|
ValarDragon
approved these changes
Nov 15, 2018
ebuchman
approved these changes
Nov 15, 2018
|
|
||
| [[constraint]] | ||
| name = "google.golang.org/grpc" | ||
| version = "=1.13.0" | ||
| version = "~1.13.0" |
There was a problem hiding this comment.
Is this being considered a serialization library? We should move it to the other section then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(at least those with releases)
because
dep ensure -update XXXCloses #2798