Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: module=main setting overrides all others #2868

Closed
ebuchman opened this issue Nov 17, 2018 · 1 comment
Closed

log: module=main setting overrides all others #2868

ebuchman opened this issue Nov 17, 2018 · 1 comment
Assignees
@melekes
Labels
C:libs Component: Library T:bug Type Bug (Confirmed) T:observability Type: Observability
Milestone
Wishlist

Comments

@ebuchman
Copy link
Contributor

I just noticed that the default log_level setting, log_level = "main:info,state:info,*:error", actually causes all modules to log at info level. This seems to be because the root logger has module=main, so all loggers derive from this and end up with the same setting as main, in this case info.

The main module doesn't log all that much, so we could just eliminate the main:info piece from the default. But we should probably fix this issue anyhow so that derivative loggers can have different levels than their parents.
@ebuchman ebuchman added T:bug Type Bug (Confirmed) T:observability Type: Observability C:libs Component: Library labels Nov 17, 2018
@ebuchman ebuchman added this to the v1.0 milestone Nov 17, 2018
@melekes melekes self-assigned this Nov 20, 2018
melekes added a commit that referenced this issue Nov 20, 2018
@melekes
return back initially allowed level if we encounter allowed key
20cfd7c 
Fixes #2868
@melekes melekes mentioned this issue Nov 20, 2018
Merged
4 tasks
melekes added a commit that referenced this issue Nov 20, 2018
@melekes
return back initially allowed level if we encounter allowed key
3a509b1 
Fixes #2868 where module=main setting overrides all others
ebuchman pushed a commit that referenced this issue Nov 26, 2018
@melekes @ebuchman
return back initially allowed level if we encounter allowed key (#2889)
98e442a 
Fixes #2868 where module=main setting overrides all others
@melekes
Copy link
Contributor

melekes commented Nov 26, 2018

PR with a fix/feature was merged to develop. Will be shipped with 0.26.4 or 0.27.0 release (check the changelog).

@melekes melekes closed this as completed Nov 26, 2018
@melekes melekes mentioned this issue Dec 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melekes melekes

Labels
C:libs Component: Library T:bug Type Bug (Confirmed) T:observability Type: Observability
Projects
None yet
Milestone
Wishlist
Development

No branches or pull requests
2 participants
@melekes @ebuchman