Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Make base config configurable on testnet cmd #3160

Closed
ebuchman opened this issue Jan 19, 2019 · 7 comments
Closed

tools: Make base config configurable on testnet cmd #3160

ebuchman opened this issue Jan 19, 2019 · 7 comments
Labels
good first issue Contributions Welcome!!

Comments

@ebuchman
Copy link
Contributor

tendermint testnet generates files for a new testnet using a default config but with the option to fill in the persistent_peers (so all the nodes connect).

We should add a --base-config option to point to an existing config file to use as the base.

This makes it easier to manipulate and share testnet environments
@ebuchman ebuchman added help wanted good first issue Contributions Welcome!! labels Jan 19, 2019
@zramsay zramsay self-assigned this Jan 22, 2019
@ebuchman ebuchman mentioned this issue Jan 23, 2019
Closed
@zramsay zramsay removed their assignment Feb 11, 2019
@qustavo
Copy link

qustavo commented Feb 22, 2019

Would tendermint testnet --home=x work in this case?

@ebuchman
Copy link
Contributor Author

I think the --home flag isn't being used by the testnet command but in theory it could look there for the config file.

@qustavo
Copy link

qustavo commented Feb 25, 2019 •
edited

I understand better now, and I think that --base-config argument is more explicit than --home.

@gregdhill gregdhill mentioned this issue Apr 14, 2019
Merged
4 tasks
@melekes
Copy link
Contributor

melekes commented Apr 15, 2019

By --base-config you mean BaseConfig field of the config OR the whole config? In the latter case, why the --base prefix?

@xla xla changed the title testnet cmd should take a --base-config option tools: testnet cmd should take a --base-config option Apr 15, 2019
@xla xla changed the title tools: testnet cmd should take a --base-config option tools: Make base config configurable on testnet cmd Apr 15, 2019
@ebuchman
Copy link
Contributor Author

I thought to include base because some of the fields could still be overwritten by other flags. But it could just be --config too without the prefix and still have that overwritting behaviour ...

@melekes
Copy link
Contributor

melekes commented Apr 16, 2019

I think we should go with the --config flag since most of the developers do not know about BaseConfig.

melekes pushed a commit that referenced this issue Apr 23, 2019
@gregdhill @melekes
testnet cmd: add config option (#3559)
968e955 
Option to explicitly provide the -config in the testnet command, closing #3160.
@melekes
Copy link
Contributor

melekes commented Apr 23, 2019

Merged #3559 to develop.

@melekes melekes closed this as completed Apr 23, 2019
brapse pushed a commit to brapse/tendermint that referenced this issue Jun 5, 2019
@gregdhill @brapse
testnet cmd: add config option (tendermint#3559)
d31a842 
Option to explicitly provide the -config in the testnet command, closing tendermint#3160.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Contributions Welcome!!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@melekes @qustavo @ebuchman @zramsay