Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend GetPubKey() to return errors #3602

Closed
jleni opened this issue Apr 29, 2019 · 0 comments · Fixed by #4534
Closed

Extend GetPubKey() to return errors #3602

jleni opened this issue Apr 29, 2019 · 0 comments · Fixed by #4534
Assignees
@tac0turtle
Labels
good first issue Contributions Welcome!! T:enhancement Type: Enhancement
Projects
Who's doing what?

Comments

@jleni
Copy link
Contributor

jleni commented Apr 29, 2019

This issue is a follow up of #3370

GetPubKey() cannot return an error at this moment.
Changes is the PrivValidator.GetPubKey() result in changes/updates in multiple places of the codebase.

Expectation: Extend GetPubKey() so errors can be returns. Adjust code, add missing error handling plus additional tests.
@jleni jleni mentioned this issue Apr 29, 2019
Merged
4 tasks
@tac0turtle tac0turtle added T:breaking Type: Breaking Change T:enhancement Type: Enhancement good first issue Contributions Welcome!! and removed help wanted labels Feb 25, 2020
tac0turtle added a commit that referenced this issue Feb 29, 2020
@tac0turtle
privval: return error on getpubkey
0afd7a0 
- return error on getpubkey
- lots of test cases fixed

closes #3602

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle removed the T:breaking Type: Breaking Change label Feb 29, 2020
@tac0turtle tac0turtle mentioned this issue Mar 5, 2020
Merged
5 tasks
@tac0turtle tac0turtle self-assigned this Mar 5, 2020
@tac0turtle tac0turtle added this to In Review in Who's doing what? Mar 10, 2020
Who's doing what? automation moved this from In Review to Done Mar 12, 2020
melekes added a commit that referenced this issue Mar 12, 2020
@tac0turtle @melekes
privval: return error on getpubkey (#4534)
48f073d 
closes #3602

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
cmwaters pushed a commit that referenced this issue Mar 25, 2020
@tac0turtle @melekes @cmwaters
privval: return error on getpubkey (#4534)
ea7a527 
closes #3602

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
good first issue Contributions Welcome!! T:enhancement Type: Enhancement
Projects
No open projects
Who's doing what?
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

privval: return error on getpubkey tendermint/tendermint
2 participants
@jleni @tac0turtle