Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: VerifyCommitX should return as soon as threashold is reached #4417

Closed
melekes opened this issue Feb 17, 2020 · 1 comment · Fixed by #4445
Closed

types: VerifyCommitX should return as soon as threashold is reached #4417

melekes opened this issue Feb 17, 2020 · 1 comment · Fixed by #4445
Assignees
@alessio
Labels
T:perf Type: Performance

Comments

@melekes
Copy link
Contributor

melekes commented Feb 17, 2020

an optimization which should increase the verification speed.

before:
verifying all the signatures

after:
verifying only 2/3+ (or in case of VerifyCommitTrusting - 1/3+) signatures
@melekes melekes added the T:perf Type: Performance label Feb 17, 2020
@tac0turtle
Copy link
Contributor

it may also help if we did batch verification of the ed25519 sigs: https://github.com/oasislabs/ed25519/blob/master/batch_verify.go

alessio pushed a commit that referenced this issue Feb 20, 2020
types.VerifyCommitX: early return when +2/3 sigs are verified
925195f 
Closes: #4417
@alessio alessio mentioned this issue Feb 20, 2020
Merged
5 tasks
melekes pushed a commit that referenced this issue Feb 25, 2020
types: VerifyCommitX return when +2/3 sigs are verified (#4445)
25d92d0 
Closes #4417
@zemyblue zemyblue mentioned this issue Mar 31, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
T:perf Type: Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

types.VerifyCommitX: early return when +2/3 sigs are verified tendermint/tendermint
3 participants
@alessio @melekes @tac0turtle