types: simplify VerifyCommitTrusting #4798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
melekes
commented
May 6, 2020
| @@ -632,9 +632,17 @@ func (vals *ValidatorSet) VerifyCommit(chainID string, blockID BlockID, | |||
| if vals.Size() != len(commit.Signatures) { | |||
There was a problem hiding this comment.
VerifyCommit should probably be renamed to ValidateAndVerifyCommit
Codecov Report
@@ Coverage Diff @@
## master #4798 +/- ##
==========================================
- Coverage 64.24% 64.19% -0.05%
==========================================
Files 220 220
Lines 20344 20342 -2
==========================================
- Hits 13069 13059 -10
- Misses 6236 6241 +5
- Partials 1039 1042 +3
|
erikgrinaker
approved these changes
May 6, 2020
fedekunze
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4783
It looks like we're validating Commit twice. Also, height and blockID params were coming from the commit, so no need to pass them separately.