-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
state: don't save genesis state in database when loaded #5231
Conversation
👋 Thanks for creating a PR! Before we can merge this PR, please make sure that all the following items have been
Thank you for your contribution to Tendermint! 🚀 |
Codecov Report
@@ Coverage Diff @@
## master #5231 +/- ##
==========================================
+ Coverage 61.45% 62.55% +1.10%
==========================================
Files 198 259 +61
Lines 23086 27190 +4104
==========================================
+ Hits 14187 17010 +2823
- Misses 7652 8703 +1051
- Partials 1247 1477 +230
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I have a little twitch when I see two functions look extremely similar but I will ignore that
Yeah, this smells fishy 🐟 |
State sync broke in #5231 since the genesis state is not propagated explicitly from `NewNode()` to `Node.OnStart()` and further into the state sync initialization. This is a hack until we can clean up the node startup process.
Fixes #5138. I don't have a strong opinion on this, but find it sort of odd that
Load
functions actually save as well.