Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statesync: check all necessary heights when adding snapshot to pool #5516

Merged
merged 4 commits into from Oct 16, 2020
Merged

statesync: check all necessary heights when adding snapshot to pool #5516

merged 4 commits into from Oct 16, 2020

Conversation

erikgrinaker
Copy link
Contributor

Fixes #5511.

@erikgrinaker erikgrinaker added the C:sync Component: Fast Sync, State Sync label Oct 16, 2020
@erikgrinaker erikgrinaker self-assigned this Oct 16, 2020
@codecov
Copy link

codecov bot commented Oct 16, 2020 •
edited

Codecov Report

Merging #5516 into master will increase coverage by 1.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #5516      +/-   ##
==========================================
+ Coverage   59.80%   61.00%   +1.19%     
==========================================
  Files         212      263      +51     
  Lines       18339    23687    +5348     
==========================================
+ Hits        10968    14450    +3482     
- Misses       6268     7759    +1491     
- Partials     1103     1478     +375
Impacted Files Coverage Δ
statesync/stateprovider.go 0.00% <0.00%> (ø)
crypto/sr25519/pubkey.go 43.47% <0.00%> (-8.70%) ⬇️
statesync/snapshots.go 91.59% <0.00%> (-1.69%) ⬇️
consensus/reactor.go 73.83% <0.00%> (-0.26%) ⬇️
p2p/netaddress.go 53.51% <0.00%> (ø)
p2p/key.go 65.85% <0.00%> (ø)
privval/errors.go 25.00% <0.00%> (ø)
mempool/reactor.go 82.57% <0.00%> (ø)
p2p/trust/store.go 68.42% <0.00%> (ø)
mempool/clist_mempool.go 83.83% <0.00%> (ø)
... and 48 more

@erikgrinaker erikgrinaker added the S:automerge Automatically merge PR when requirements pass label Oct 16, 2020
@mergify mergify bot merged commit e7184c4 into master Oct 16, 2020
@mergify mergify bot deleted the erik/statesync-check-heights branch October 16, 2020 11:47
erikgrinaker added a commit that referenced this pull request Oct 16, 2020
@erikgrinaker
statesync: check all necessary heights when adding snapshot to pool (#…
eb13097 
…5516)

Fixes #5511.
@erikgrinaker erikgrinaker mentioned this pull request Oct 16, 2020
Merged
erikgrinaker added a commit that referenced this pull request Oct 16, 2020
@erikgrinaker
statesync: check all necessary heights when adding snapshot to pool (#…
b3238cd 
…5516) (#5518)

Fixes #5511.
@cmwaters cmwaters mentioned this pull request Feb 22, 2022
Merged
This was referenced Apr 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

@tessr tessr Awaiting requested review from tessr

Assignees

@erikgrinaker erikgrinaker

Labels
C:sync Component: Fast Sync, State Sync S:automerge Automatically merge PR when requirements pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statesync: fails to restore snapshots taken at current chain head
2 participants
@erikgrinaker @melekes