New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mempool: handle out-of-order ABCI responses #5519
Projects
Comments
erikgrinaker
added a commit
that referenced
this issue
Oct 20, 2020
erikgrinaker
added a commit
that referenced
this issue
Oct 20, 2020
8 tasks
When I spoke to @ebuchman about this for clarification on the v1 mempool, I recall that we're guaranteed to get the responses in the order in which they were executed. |
for unix, tcp and in process this is the case, but with gRPC the issue above arises. |
4 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The mempool currently seems to require asynchronous ABCI calls to returns responses in the same order they were called - e.g.
CListMempool.recheckCursor
has an ordered list of transactions to recheck, but callsCheckTxAsync
to actually recheck them, which may return responses in a different order.This caused #5439, since the gRPC ABCI client, although serial in nature, used unordered goroutines to simulate async responses in order to satisfy the async API semantics.
The text was updated successfully, but these errors were encountered: