os: simplify EnsureDir() #5871
Merged
os: simplify EnsureDir() #5871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5871 +/- ##
==========================================
- Coverage 59.98% 59.91% -0.08%
==========================================
Files 263 263
Lines 23858 23858
==========================================
- Hits 14312 14294 -18
- Misses 8021 8032 +11
- Partials 1525 1532 +7
|
alexanderbez
approved these changes
Jan 6, 2021
erikgrinaker
added a commit
that referenced
this pull request
Jan 6, 2021
#5852 fixed an issue with error propagation in `os.EnsureDir()`. However, this function is basically identical to `os.MkdirAll()`, and can be replaced entirely with a call to it. We keep the function for backwards compatibility.
erikgrinaker
added a commit
that referenced
this pull request
Jan 6, 2021
#5852 fixed an issue with error propagation in `os.EnsureDir()`. However, this function is basically identical to `os.MkdirAll()`, and can be replaced entirely with a call to it. We keep the function for backwards compatibility.
This was referenced Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5852 fixed an issue with error propagation in
os.EnsureDir(). However, this function is basically identical toos.MkdirAll(), and can be replaced entirely with a call to it. We keep the function for backwards compatibility.