libs/os: EnsureDir now returns IO errors and checks file type #5852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgrinaker
requested review from
ebuchman,
tac0turtle,
melekes and
tessr
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5852 +/- ##
==========================================
+ Coverage 59.94% 59.99% +0.04%
==========================================
Files 263 263
Lines 23817 23822 +5
==========================================
+ Hits 14277 14291 +14
+ Misses 8032 8019 -13
- Partials 1508 1512 +4
|
alexanderbez
approved these changes
Jan 4, 2021
Comment on lines
+46
to
+47
| err = os.MkdirAll(dir, mode) | ||
| if err != nil { |
There was a problem hiding this comment.
nit: can make this a one-liner
mergify bot
pushed a commit
that referenced
this pull request
Jan 6, 2021
#5852 fixed an issue with error propagation in `os.EnsureDir()`. However, this function is basically identical to `os.MkdirAll()`, and can be replaced entirely with a call to it. We keep the function for backwards compatibility.
erikgrinaker
added a commit
that referenced
this pull request
Jan 6, 2021
erikgrinaker
added a commit
that referenced
this pull request
Jan 6, 2021
#5852 fixed an issue with error propagation in `os.EnsureDir()`. However, this function is basically identical to `os.MkdirAll()`, and can be replaced entirely with a call to it. We keep the function for backwards compatibility.
erikgrinaker
added a commit
that referenced
this pull request
Jan 6, 2021
erikgrinaker
added a commit
that referenced
this pull request
Jan 6, 2021
#5852 fixed an issue with error propagation in `os.EnsureDir()`. However, this function is basically identical to `os.MkdirAll()`, and can be replaced entirely with a call to it. We keep the function for backwards compatibility.
This was referenced Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5839.