rpc/jsonrpc/server: return an error in WriteRPCResponseHTTP(Error) #6204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of panicking Closes #5529
melekes
added
the
S:backport-to-v0.34.x
Codecov Report
@@ Coverage Diff @@
## master #6204 +/- ##
==========================================
+ Coverage 60.72% 60.79% +0.06%
==========================================
Files 276 276
Lines 25788 25788
==========================================
+ Hits 15659 15677 +18
+ Misses 8508 8487 -21
- Partials 1621 1624 +3
|
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
|
Am I correct in thinking this will fix my validator going MIA for a brief period (a block or two) with repeating
Never mind: I saw that #6078 and #5529 together described my situation, and the current PR looks like it solves it completely. |
8 tasks
tac0turtle
added a commit
that referenced
this pull request
Mar 17, 2021
…#6204) (#6230) * rpc/jsonrpc/server: return an error in WriteRPCResponseHTTP(Error) (#6204) instead of panicking Closes #5529 (cherry picked from commit 00b9524) # Conflicts: # CHANGELOG_PENDING.md # rpc/jsonrpc/server/http_json_handler.go # rpc/jsonrpc/server/http_server.go # rpc/jsonrpc/server/http_server_test.go # rpc/jsonrpc/server/http_uri_handler.go * resolve conflicts * fix linting * fix conflict Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Marko Baricevic <marbar3778@yahoo.com>
This was referenced Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of panicking
Closes #5529