Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light: handle too high errors correctly #6346

Merged
merged 2 commits into from Apr 13, 2021
Merged

light: handle too high errors correctly #6346

merged 2 commits into from Apr 13, 2021

Conversation

cmwaters
Copy link
Contributor

This was causing some robutness faults in the state sync and was missed out when writing up the light client security issue

@cmwaters cmwaters added C:light Component: Light S:backport-to-v0.34.x Tell mergify to backport the PR to v0.34.x labels Apr 13, 2021
@codecov
Copy link

codecov bot commented Apr 13, 2021 •
edited

Codecov Report

Merging #6346 (d414c12) into master (b517dd5) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #6346      +/-   ##
==========================================
+ Coverage   60.90%   60.92%   +0.01%     
==========================================
  Files         282      282              
  Lines       26866    26866              
==========================================
+ Hits        16362    16367       +5     
+ Misses       8804     8797       -7     
- Partials     1700     1702       +2
Impacted Files Coverage Δ
light/client.go 73.24% <33.33%> (ø)
statesync/syncer.go 79.60% <0.00%> (-1.61%) ⬇️
mempool/reactor.go 73.04% <0.00%> (-1.42%) ⬇️
abci/client/socket_client.go 38.54% <0.00%> (-1.15%) ⬇️
p2p/conn/connection.go 78.51% <0.00%> (-0.56%) ⬇️
p2p/transport_memory.go 86.48% <0.00%> (ø)
proxy/multi_app_conn.go 48.05% <0.00%> (ø)
p2p/switch.go 58.74% <0.00%> (+0.69%) ⬆️
blockchain/v0/pool.go 79.84% <0.00%> (+0.76%) ⬆️
p2p/transport_mconn.go 82.67% <0.00%> (+0.99%) ⬆️
... and 4 more

tac0turtle
tac0turtle approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though its a small change, could we get a changelog entry please

@cmwaters cmwaters merged commit d4d2b66 into master Apr 13, 2021
@cmwaters cmwaters deleted the callum/light-errors branch April 13, 2021 12:21
mergify bot pushed a commit that referenced this pull request Apr 13, 2021
@cmwaters
light: handle too high errors correctly (#6346)
15a59a1 
(cherry picked from commit d4d2b66)

# Conflicts:
#	CHANGELOG_PENDING.md
#	light/client.go
@mergify mergify bot mentioned this pull request Apr 13, 2021
Merged
cmwaters pushed a commit that referenced this pull request Apr 13, 2021
@mergify
light: handle too high errors correctly (backport #6346) (#6351)
6cc3e23
tychoish pushed a commit that referenced this pull request Apr 14, 2021
@cmwaters @tychoish
light: handle too high errors correctly (#6346)
9266349
@cmwaters cmwaters mentioned this pull request Apr 14, 2021
Closed
@cmwaters cmwaters mentioned this pull request Feb 22, 2022
Merged
This was referenced Apr 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@tessr tessr Awaiting requested review from tessr

@tychoish tychoish Awaiting requested review from tychoish

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
C:light Component: Light S:backport-to-v0.34.x Tell mergify to backport the PR to v0.34.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmwaters @tac0turtle