New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No way to send from VM #65
Comments
Merged
+1 Also wrote on the comments for the PR |
ebuchman
added a commit
that referenced
this issue
Jun 20, 2018
ebuchman
added a commit
that referenced
this issue
Jun 20, 2018
[autofile] Support for the new WAL format
yutianwu
pushed a commit
to yutianwu/tendermint
that referenced
this issue
Jun 5, 2019
[R4R]p2p: do not log err if peer is private
faddat
pushed a commit
to faddat/tendermint
that referenced
this issue
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unless I'm missing something, there is no way to send funds from a contract to an account. Presumably this would be done with the CALL opcode, but that simply calls
vm.Call(...)
which panics if there is no code passed in. Instead, we should remove the panic, do the transfer, and then return if there's no code. This is more or less what happens in go-eth. Also CALL expects the destination account to exist, and returns an error if it doesn't, so we might have to remove that check so the contract can send funds to a new account. Happy to fix it once you acknowledge.The text was updated successfully, but these errors were encountered: