rpc: log update #6825
Merged
rpc: log update #6825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
cmwaters,
creachadair,
ebuchman,
tessr,
tychoish and
williambanfield
as code owners
alexanderbez
added
S:backport-to-v0.34.x
Codecov Report
@@ Coverage Diff @@
## master #6825 +/- ##
==========================================
+ Coverage 62.71% 62.75% +0.04%
==========================================
Files 307 307
Lines 40467 40466 -1
==========================================
+ Hits 25379 25396 +17
+ Misses 13300 13291 -9
+ Partials 1788 1779 -9
|
|
I don't think so tbh @tychoish |
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2021
We INFO log every `ABCIQuery`. This can output a tremendous amount of noise in the logs, can cause cosmovisor to completely crash and slows down the node due to I/O. This log is completely unnecessary. Let's get this backported into v0.43 and get that into v0.43 and v0.42 releases of the SDK /cc @marbar3778 (cherry picked from commit 393a02a) # Conflicts: # CHANGELOG_PENDING.md
alexanderbez
pushed a commit
that referenced
this pull request
Aug 14, 2021
|
Amazing, thanks for getting this in |
|
I think it would make sense to include it in debug, but not include the response FWIW |
This was referenced Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We INFO log every
ABCIQuery. This can output a tremendous amount of noise in the logs, can cause cosmovisor to completely crash and slows down the node due to I/O. This log is completely unnecessary.Let's get this backported into v0.43 and get that into v0.43 and v0.42 releases of the SDK
/cc @marbar3778