Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types.ConsensusParams: document the maximum hard limit on BlockSizeParams.MaxBytes #747

Closed
odeke-em opened this issue Oct 15, 2017 · 0 comments
Closed

types.ConsensusParams: document the maximum hard limit on BlockSizeParams.MaxBytes #747

odeke-em opened this issue Oct 15, 2017 · 0 comments
Assignees
@ebuchman @zramsay

Comments

@odeke-em
Copy link
Contributor

I was just reading through

tendermint/types/params.go

Line 82 in d4634dc

if params.BlockSizeParams.MaxBytes > maxBlockSizeBytes {

in order to write tests and noticed that the maximum hard limit is an unexposed constant that doesn't seem to be documented anywhere. Perhaps we should document this hardlimit.
odeke-em added a commit that referenced this issue Oct 15, 2017
@odeke-em
types: ConsensusParams test + document the ranges/limits
22b944b 
Fixes #747
Updates #693

* Document the unmentioned limits for ConsensusParams.Validate()
* Make the limit for ConsensusParams.BlockSizeParams.MaxBytes
clear at 100MiB
odeke-em added a commit that referenced this issue Oct 15, 2017
@odeke-em
types: ConsensusParams test + document the ranges/limits
afc27ea 
Fixes #747
Updates #693

* Document the unmentioned limits for ConsensusParams.Validate()
* Make the limit for ConsensusParams.BlockSizeParams.MaxBytes
clear at 100MiB
odeke-em added a commit that referenced this issue Oct 15, 2017
@odeke-em
types: ConsensusParams test + document the ranges/limits
14b7821 
Fixes #747
Updates #693

* Document the unmentioned limits for ConsensusParams.Validate()
* Make the limit for ConsensusParams.BlockSizeParams.MaxBytes
clear at 100MiB
@odeke-em odeke-em mentioned this issue Oct 15, 2017
Merged
odeke-em added a commit that referenced this issue Oct 16, 2017
@odeke-em
types: ConsensusParams test + document the ranges/limits
bff069f 
Fixes #747
Updates #693

* Document the unmentioned limits for ConsensusParams.Validate()
* Make the limit for ConsensusParams.BlockSizeParams.MaxBytes
clear at 100MiB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebuchman ebuchman

@zramsay zramsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ebuchman @odeke-em @zramsay