Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventBus interface #893

Closed
melekes opened this issue Nov 24, 2017 · 0 comments
Closed

EventBus interface #893

melekes opened this issue Nov 24, 2017 · 0 comments

Comments

@melekes
Copy link
Contributor

melekes commented Nov 24, 2017

#886 (comment)

@melekes melekes closed this as completed Dec 10, 2017
cmwaters added a commit to cmwaters/tendermint that referenced this issue Dec 12, 2022
* chore!: remove original tx from the abci.TxResult

* chore!: remove the original hash from malleated txs

* fix: remove remaining original hash

* feat!: add wrapper funcs for blob transactions

* chore!: track blob txs in the mempool

* chore!: add stronger protections against false positives while decoding by adding a typeID

* fix: test malleated tx indexing

* fix: comment

* fix: use more accurate arg name in wrap malleated

* Apply suggestions from code review

Co-authored-by: Rootul P <rootulp@gmail.com>

* chore: proto-format and proto-gen to add comments

* chore: docs

Co-authored-by: Rootul P <rootulp@gmail.com>

* chore: rename unwrapped to unmarshal

* fix: remaining renames

* fix!: pass the entire blob transaction to the application

Co-authored-by: Callum Waters <cmwaters19@gmail.com>

* feat!: modify tx.Key and tx.Hash to unwrap the tx before calculating the hash

* Revert "chore!: track blob txs in the mempool"

This reverts commit a6e28ae1d4a096a6ad5834e37218016c561bd42f.

* fix: clean up revert

* chore: docs

Co-authored-by: Rootul P <rootulp@gmail.com>

* chore: add docs and optimize unmarshalling of transactions when calculating the hash or the key

* chore!: wrap/unwrap -> marshal/unmarshal

* fix: update test

* fix: use existing transaction to calculate len

Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this issue Feb 1, 2024
…endermint#893)

Bumps [github.com/vektra/mockery/v2](https://github.com/vektra/mockery) from 2.27.1 to 2.28.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/vektra/mockery/releases">github.com/vektra/mockery/v2's releases</a>.</em></p>
<blockquote>
<h2>v2.28.1</h2>
<h2>Changelog</h2>
<ul>
<li>423eab1 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/635">#635</a> from adolsalamanca/adol/fix-pathlib-version</li>
<li>2c4bf4d fix pathlib version</li>
</ul>
<h2>v2.28.0</h2>
<h2>Changelog</h2>
<ul>
<li>311c394 Add reference to packages feature section</li>
<li>0e49266 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/627">#627</a> from almas1992/patch-1</li>
<li>d0c93f6 Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/629">#629</a> from dillonstreator/expecter-structs-with-rolled-variadics</li>
<li>425c292 Update examples.md</li>
<li>15a308a adjust testing pattern</li>
<li>b964d01 clarify variadic docs</li>
<li>db3556e fix broken link</li>
<li>fe8de93 fix packages docs</li>
<li>25091d2 support rolled variadics with expecter structs</li>
<li>ae9feff test should use require and remove incorrect messages</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/vektra/mockery/commit/423eab1600e9abda3c744a10f65d9c1b0e3ea143"><code>423eab1</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/635">#635</a> from adolsalamanca/adol/fix-pathlib-version</li>
<li><a href="https://github.com/vektra/mockery/commit/2c4bf4d84e572475776541e4d3b1cbf83a0b8f44"><code>2c4bf4d</code></a> fix pathlib version</li>
<li><a href="https://github.com/vektra/mockery/commit/d0c93f68acd86ea733ffe9cc40514c25d47348df"><code>d0c93f6</code></a> Merge pull request <a href="https://redirect.github.com/vektra/mockery/issues/629">#629</a> from dillonstreator/expecter-structs-with-rolled-vari...</li>
<li><a href="https://github.com/vektra/mockery/commit/ae9feff9a32024c2741a339256e51798d616919d"><code>ae9feff</code></a> test should use require and remove incorrect messages</li>
<li><a href="https://github.com/vektra/mockery/commit/15a308a66ef70fba9a58666659ed89a8ec0863a3"><code>15a308a</code></a> adjust testing pattern</li>
<li><a href="https://github.com/vektra/mockery/commit/25091d2c8a17597369aa0ee736d6831a98c85113"><code>25091d2</code></a> support rolled variadics with expecter structs</li>
<li><a href="https://github.com/vektra/mockery/commit/b964d013bc945973178edccc57f14c56ec7234ad"><code>b964d01</code></a> clarify variadic docs</li>
<li><a href="https://github.com/vektra/mockery/commit/db3556ec75be97771b098f6cb74437ba6c2ba705"><code>db3556e</code></a> fix broken link</li>
<li><a href="https://github.com/vektra/mockery/commit/311c3941b88f5b6c2772968d07d4097e8143d675"><code>311c394</code></a> Add reference to packages feature section</li>
<li><a href="https://github.com/vektra/mockery/commit/fe8de9338a31918ecd2add2b5251daa449d29904"><code>fe8de93</code></a> fix packages docs</li>
<li>Additional commits viewable in <a href="https://github.com/vektra/mockery/compare/v2.27.1...v2.28.1">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/vektra/mockery/v2&package-manager=go_modules&previous-version=2.27.1&new-version=2.28.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant