Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples in proposer selection specification #9346

Closed
nashqueue opened this issue Aug 31, 2022 · 0 comments · Fixed by #9375
Closed

Fix examples in proposer selection specification #9346

nashqueue opened this issue Aug 31, 2022 · 0 comments · Fixed by #9375
Assignees
Labels
C:spec Component: specification

Comments

@nashqueue
Copy link
Contributor

Protocol Change Proposal

Summary

Change examples in Tendermint specifications in proposer selection for consistency.

Problem Definition

What problems may be addressed by introducing this change?
The examples have, in my opinion, some minor mistakes.
What benefits does Tendermint stand to gain by including this change?
Specs are easier to understand.
Are there any disadvantages of including this change? --> I don't think so

Proposal

Validator Removal

The priority should be from -3 to 3
After new step, the priority from p1 should increase by 1 from 2 to 3 as it has VP 1

New Validator

The new proposer priority of p3 should be set to -13 and not -4 in Alg step

Proposer Priority Change

After you add p2 and run a selection, the priority of p1 is 45k and of p2 is -45k. The signs a flipped in the first Table.

PS: I failed to do the rebase in #9326, so I am abandoning it and trying to do it right from the start, starting with an issue.

@thanethomson thanethomson added the C:spec Component: specification label Aug 31, 2022
adizere added a commit that referenced this issue Nov 21, 2022
This PR resolves #9346

Co-authored-by: Adi Seredinschi <adizere@gmail.com>
Co-authored-by: Adi Seredinschi <a@seredinschi.net>
@adizere adizere changed the title Change examples in proposer selection sepcification. Fix examples in proposer selection specification Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:spec Component: specification
Projects
Status: Done/Merged
Development

Successfully merging a pull request may close this issue.

3 participants