fix memory leak #1156
Closed
fix memory leak #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs cosmos/gaia#108 Test case: ``` func TestSwitchMemoryLeak(t *testing.T) { sw := MakeSwitch(config, 1, "testing", "123.123.123", initSwitchFunc) err := sw.Start() if err != nil { t.Error(err) } defer sw.Stop() // simulate remote peer rp := &remotePeer{PrivKey: crypto.GenPrivKeyEd25519().Wrap(), Config: DefaultPeerConfig()} rp.Start() defer rp.Stop() p, err := newOutboundPeer(rp.Addr(), sw.reactorsByCh, sw.chDescs, sw.StopPeerForError, sw.nodeKey.PrivKey, DefaultPeerConfig(), true) require.Nil(t, err) id := p.ID() err = sw.addPeer(p) require.Nil(t, err) f, err := os.Create("/tmp/mem1.mprof") if err != nil { t.Fatal(err) } pprof.WriteHeapProfile(f) f.Close() fmt.Println(runtime.NumGoroutine()) // simulate failure by closing connection p.CloseConn() npeers := sw.Peers().Size() for i := 0; i < 100; i++ { time.Sleep(250 * time.Millisecond) npeers = sw.Peers().Size() if npeers > 0 { // simulate failure by closing connection sw.Peers().Get(id).(*peer).CloseConn() } } runtime.GC() f, err = os.Create("/tmp/mem2.mprof") if err != nil { t.Fatal(err) } pprof.WriteHeapProfile(f) f.Close() fmt.Println(runtime.NumGoroutine()) } ```
|
Data races |
|
Yah, sorry. Hm.. looks like we're using peer after we stopped it.. duh |
|
Needs more ❤️ |
|
Running goroutines: |
|
ok, so some consensus reactor is definitely holding a reference to a peer. that's why it's not garbage collected. see also https://stackoverflow.com/questions/48499573/is-there-a-way-to-know-who-holds-a-reference-to-an-object-in-go |
|
mempool reactor |
|
melekes
added a commit
that referenced
this pull request
Jan 30, 2018
Leaking goroutine: ``` 114 @ 0x42f2bc 0x42f3ae 0x440794 0x4403b9 0x468002 0x9fe32d 0x9ff78f 0xa025ed 0x45e571 ``` Explanation: it blocks on an empty clist forever. so unless theres txs coming in, this go routine will just sit there, holding onto the peer too. if we're constantly reconnecting to some peer, old instances are not garbage collected, leading to memory leak. Fixes cosmos/gaia#108 Previous attempt #1156
melekes
added a commit
that referenced
this pull request
Feb 5, 2018
Leaking goroutine: ``` 114 @ 0x42f2bc 0x42f3ae 0x440794 0x4403b9 0x468002 0x9fe32d 0x9ff78f 0xa025ed 0x45e571 ``` Explanation: it blocks on an empty clist forever. so unless theres txs coming in, this go routine will just sit there, holding onto the peer too. if we're constantly reconnecting to some peer, old instances are not garbage collected, leading to memory leak. Fixes cosmos/gaia#108 Previous attempt #1156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs cosmos/gaia#108
Test case: