Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge abci #1790

Merged
merged 668 commits into from Jun 22, 2018
Merged

Merge abci #1790

merged 668 commits into from Jun 22, 2018

Conversation

xla
Copy link
Contributor

@xla xla commented Jun 22, 2018 •
edited

Replaces #1780

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

ebuchman and others added 30 commits November 27, 2017 22:41
@ebuchman
Merge pull request #130 from tendermint/feature/tags-in-deliver-tx
460c045 
Tags in DeliverTx response
@odeke-em
tests: sunset tmlibs/process.Process
6231652 
Updates tendermint/tmlibs#81

No longer using tmlibs/process.Process as we deemed
it racy and would incur a maintenance cost yet not
used anywhere else but in these tests and not in actual
code.
@ebuchman
tests: fix ensureABCIIsUp
9ed5787
@ebuchman
client: use vars for retry intervals
bb14179
@ebuchman
run linter on make test
67a81c1
@ebuchman
Merge pull request #139 from tendermint/sunset-tmlibs-process
5c29adc 
tests: sunset tmlibs/process.Process
@melekes
include tags into dummy application DeliverTx response
72c3ea3 
Refs #835
@ebuchman
dummy: include app.key tag
3b994b4
@ebuchman
changelog [ci skip]
32a6545
@ebuchman
Merge pull request #141 from tendermint/feature/add-tags-to-dummy-app
b89fd81 
include tags into dummy application DeliverTx response
@melekes
add 2 helper methods for building KVPair(s)
20befcf
@melekes
Merge pull request #144 from tendermint/feature/tags-helper-methods
22b491b 
add 2 helper methods for building KVPair(s)
@ebuchman
remove CodeType
42a8e32
@ebuchman
use gogo/protobuf
308cb8e
@ebuchman
update glide; update services for new signature
24fbe29
@ebuchman
types: use data.Bytes directly in type.proto via gogo/protobuf. wow
81e4eff
@ebuchman
shame: forgot to add new code pkg
550d6a6
@ebuchman
fix grpc version; add log_level and some logging
10031f5
@ebuchman
fix tutorial output to remove code msg
f00a19e
@ebuchman
update changelog; add rudis script for safe keeping
e3f6666
@ebuchman
abci-cli: print OK if code is 0
ed393f9
@ebuchman
fix from review
5d2838e
@ebuchman
Merge pull request #145 from tendermint/types-makeover
d9d5e35 
Types makeover
@ebuchman
abci-cli: prefix flag variables with flag
b59fe60
@ebuchman
uint64 -> int64
0ad7dea
@ebuchman
update readme
b7a75ce
@ebuchman
disable metalinter on CI
b39e768
@ebuchman
types: consolidate some file
3d3d128
@ebuchman
types: add note about ReadMessage having no cap
9272756
@ebuchman
types: RequestBeginBlock includes absent and byzantine validators
b202734
@xla xla added the T:enhancement Type: Enhancement label Jun 22, 2018
@xla xla added this to the launch milestone Jun 22, 2018
@xla xla self-assigned this Jun 22, 2018
@xla xla mentioned this pull request Jun 22, 2018
Closed
@xla xla force-pushed the xla/merge-abci-tmlibs branch 2 times, most recently from d815a55 to a605b66 Compare June 22, 2018 05:26
@codecov-io
Copy link

codecov-io commented Jun 22, 2018 •
edited

Codecov Report

Merging #1790 into develop will increase coverage by 1.09%.
The diff coverage is 73.65%.

@@             Coverage Diff             @@
##           develop    #1790      +/-   ##
===========================================
+ Coverage    62.37%   63.46%   +1.09%     
===========================================
  Files          140      142       +2     
  Lines        11887    11639     -248     
===========================================
- Hits          7414     7387      -27     
+ Misses        3785     3577     -208     
+ Partials       688      675      -13
Impacted Files Coverage Δ
mempool/mempool.go 68.77% <ø> (ø) ⬆️
rpc/core/abci.go 0% <ø> (ø) ⬆️
state/services.go 38.46% <ø> (ø) ⬆️
mempool/reactor.go 65.85% <ø> (ø) ⬆️
rpc/grpc/types.pb.go 40.54% <ø> (ø) ⬆️
state/execution.go 70.96% <ø> (ø) ⬆️
rpc/core/mempool.go 0% <ø> (ø) ⬆️
consensus/wal_generator.go 75.72% <ø> (ø) ⬆️
consensus/replay.go 54.85% <ø> (ø) ⬆️
state/store.go 69.91% <ø> (ø) ⬆️
... and 26 more

@xla xla force-pushed the xla/merge-abci-tmlibs branch 6 times, most recently from 266dad0 to 77573a1 Compare June 22, 2018 18:07
@xla xla changed the title wip: Merge abci Merge abci Jun 22, 2018
@xla xla mentioned this pull request Jun 22, 2018
Closed
melekes
melekes reviewed Jun 22, 2018
View reviewed changes
abci/CHANGELOG.md Outdated
@@ -1,352 +0,0 @@
# Changelog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd keep it for history purposes.

@xla xla merged commit e39e43f into develop Jun 22, 2018
@xla xla deleted the xla/merge-abci-tmlibs branch June 22, 2018 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees

@xla xla

Labels
C:abci Component: Application Blockchain Interface T:enhancement Type: Enhancement
Projects
None yet
Milestone
Wishlist
Development

Successfully merging this pull request may close these issues.

None yet