Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configurable params, other fixes #192

Merged
merged 9 commits into from
Mar 6, 2016
Merged

configurable params, other fixes #192

merged 9 commits into from
Mar 6, 2016

Conversation

ebuchman
Copy link
Contributor

@ebuchman ebuchman commented Mar 5, 2016

Changes and fixes resulting from the benchmarking effort (https://github.com/tendermint/network_testing)

  • Now configurable from config.yaml: consensus timeouts, block size (including -1 to ignore mempool txs when proposing), recheck tx, mempool broadcasting
  • cswal fixes and light mode (doesn't record block parts). closes ConsensusState.OnStop() must wait for cswal to close #186 and move cswal file to data dir #184
  • unsafe_set_config rpc command. used especially to toggle block_size so blocks don't include txs until we want them to. note not all config values can be changed this way depending on if they are assigned to variables (maybe we change this on a case by case basis. currently consensus timeouts are not updateable but maybe we want them to be)
  • fix bug where peer round states were able to decrease (we don't gaurantee order on consensus message broadcasts)

jaekwon
jaekwon reviewed Mar 6, 2016
View reviewed changes
consensus/state.go
@@ -278,13 +319,16 @@ func (cs *ConsensusState) startRoutines(maxSteps int) {

func (cs *ConsensusState) OnStop() {
cs.QuitService.OnStop()
if cs.wal != nil && cs.IsRunning() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cs.IsRunning() should always be true, based on QuiteServe/BaseService logic, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cs might not be running, eg during fast sync

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right.

jaekwon added a commit that referenced this pull request Mar 6, 2016
@jaekwon
Merge pull request #192 from tendermint/params
fd85d0e 
configurable params, other fixes
@jaekwon jaekwon merged commit fd85d0e into master Mar 6, 2016
@ebuchman ebuchman deleted the params branch March 15, 2016 02:14
ebuchman added a commit that referenced this pull request Jun 20, 2018
@ebuchman
Merge pull request #192 from tendermint/feature/fix_glide_yaml
b1e29d2 
Pin tmlibs to develop
troian pushed a commit to akash-network/tendermint that referenced this pull request Mar 11, 2023
@lasarojc
Update proto files, missing from PR 156 (tendermint#192)
db33c27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConsensusState.OnStop() must wait for cswal to close
2 participants
@ebuchman @jaekwon