libs: Make bitarray functions lock parameters that aren't the caller #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now makes bit array functions which take in a second bit array, thread safe. Previously there was a warning on bitarray.Update to be lock the second parameter externally if thread safety wasrequired. This was not done within the codebase, so it was fine to change here. Closes #2080
Codecov Report
@@ Coverage Diff @@
## develop #2081 +/- ##
===========================================
- Coverage 62.75% 62.65% -0.11%
===========================================
Files 215 215
Lines 17277 17344 +67
===========================================
+ Hits 10843 10867 +24
- Misses 5546 5591 +45
+ Partials 888 886 -2
|
xla
approved these changes
Jul 27, 2018
🍡| defer func() { | ||
| bA.mtx.Unlock() | ||
| o.mtx.Unlock() | ||
| }() |
There was a problem hiding this comment.
Why not:
a.mtx.Lock()
defer a.mtx.Unlock()
o.mtx.Lock
defer o.mtx.UnlockThere was a problem hiding this comment.
The reason I didn't bundle the defers is because my understanding is that each defer call is kinda slow: golang/go#14939
Do you think the performance should matter here? Its a bit of a micro-performance tweak, and its not at all clear that it applies here, so I'd be happy to switch to the more easy to maintain version :)
There was a problem hiding this comment.
As it is to be expected that BitArray might be used in tight loops this is a valid concern.
| defer func() { | ||
| bA.mtx.Unlock() | ||
| o.mtx.Unlock() | ||
| }() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now makes bit array functions which take in a second bit array, thread
safe. Previously there was a warning on bitarray.Update to be lock the
second parameter externally if thread safety wasrequired.
This was not done within the codebase, so it was fine to change here.
Closes #2080