Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix amino overhead computation for Tx #2792

Merged
merged 7 commits into from Nov 11, 2018
Merged

fix amino overhead computation for Tx #2792

merged 7 commits into from Nov 11, 2018

Commits on Nov 9, 2018

  1. fix amino overhead computation for Tx: 

    - also count the fieldnum / typ3
- add method to compute overhead per Tx
- slightly clarify comment on MaxAminoOverheadForBlock
- add tests
    @liamsi
    liamsi committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    8b62789 View commit details
    Browse the repository at this point in the history

  2. fix TestReapMaxBytesMaxGas according to amino overhead

    @liamsi
    liamsi committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    f815629 View commit details
    Browse the repository at this point in the history

  3. fix TestMempoolFilters according to amino overhead

    @liamsi
    liamsi committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    2ab4a40 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2018

  1. address review comments: 

     - add a note about fieldNum = 1
 - add forgotten godoc comment
    @liamsi
    liamsi committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    c746d93 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2018

  1. fix and use sm.TxPreCheck

    @ebuchman
    ebuchman committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    1f5f32f View commit details
    Browse the repository at this point in the history

  2. fix test

    @ebuchman
    ebuchman committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    6ea93fe View commit details
    Browse the repository at this point in the history

  3. remove print statement

    @ebuchman
    ebuchman committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    cabc2fc View commit details
    Browse the repository at this point in the history