dont fast sync if we have +2/3 of the voting power #2917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2917 +/- ##
==========================================
Coverage ? 62.25%
==========================================
Files ? 212
Lines ? 17288
Branches ? 0
==========================================
Hits ? 10763
Misses ? 5619
Partials ? 906
|
ValarDragon
reviewed
Nov 26, 2018
| } | ||
| ourAddr := privValidator.GetAddress() | ||
| _, val := state.Validators.GetByAddress(ourAddr) | ||
| if val != nil && val.VotingPower > state.Validators.TotalVotingPower()*2/3 { |
There was a problem hiding this comment.
This is another case where we require total voting power to be smaller than its max value. (In this case less than 2**62, previous mention of need for a requirement: #2785 (comment))
|
Actually on second thought, I'm unsure we want this. A node with 2/3rds of stake may want to spawn a replica and therefore still need to fast sync. Now they would have to pick another privkey, sync, and then switch to their main node id, which seems like a lot of overhead. |
|
I think you're right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2916