Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize priorities to not exceed total voting power #3049

Merged
merged 26 commits into from
Jan 19, 2019
Merged

Normalize priorities to not exceed total voting power #3049

merged 26 commits into from
Jan 19, 2019

Commits on Dec 4, 2018

  1. more proposer priority tests 

     - test that we don't reset to zero when updating / adding
 - test that same power validators alternate
    @liamsi
    liamsi committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    d693ca9 View commit details
    Browse the repository at this point in the history

  2. add another test to track / simulate similar behaviour as in #2960

    @liamsi
    liamsi committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    2e1630f View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. address some of Chris' review comments

    @liamsi
    liamsi committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    08c891c View commit details
    Browse the repository at this point in the history

  2. address some more of Chris' review comments

    @liamsi
    liamsi committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    c0b036f View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. temporarily pushing branch with the following changes: 

    The total power might change if:
   - a validator is added
   - a validator is removed
   - a validator is updated

Decrement the accums (of all validators) directly after any of these events
(by the inverse of the change)
    @liamsi
    liamsi committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    cd3cae6 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Fix 2960 by re-normalizing / scaling priorities to be in bounds of total 

    power, additionally:

 - remove heap where it doesn't make sense
 - avg. only at the end of IncrementProposerPriority instead of each
   iteration
 - update (and slightly improve)
   TestAveragingInIncrementProposerPriorityWithVotingPower to reflect
   above changes
    @liamsi
    liamsi committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    d6baedc View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2018

  1. Fix 2960 by re-normalizing / scaling priorities to be in bounds of total 

    power, additionally:

 - remove heap where it doesn't make sense
 - avg. only at the end of IncrementProposerPriority instead of each
   iteration
 - update (and slightly improve)
   TestAveragingInIncrementProposerPriorityWithVotingPower to reflect
   above changes
    @liamsi
    liamsi committed Dec 10, 2018
    Configuration menu
    Copy the full SHA
    e83b377 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2018

  1. Merge branch '2960_normalize_prios' of https://github.com/tendermint/… 

    …tendermint into 2960_normalize_prios
    @liamsi
    liamsi committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    9b0838e View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2018

  1. fix tests

    @liamsi
    liamsi committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    0943644 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. merge in develop

    @liamsi
    liamsi committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    3e3ad9e View commit details
    Browse the repository at this point in the history

  2. add comment

    @liamsi
    liamsi committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    d4be7e3 View commit details
    Browse the repository at this point in the history

  3. update changelog pending & some minor changes

    @liamsi
    liamsi committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    13fbda4 View commit details
    Browse the repository at this point in the history

  4. comment about division will floor the result & fix typo

    @liamsi
    liamsi committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    fc7e3ee View commit details
    Browse the repository at this point in the history

  5. Update TestLargeGenesisValidator: 

     - remove TODO and increase large genesis validator's voting power
accordingly
    @liamsi
    liamsi committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    e748114 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2019

  1. move changelog entry to P2P Protocol

    @liamsi
    liamsi committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    f677989 View commit details
    Browse the repository at this point in the history

  2. Ceil instead of flooring when dividing & update test

    @liamsi
    liamsi committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    449bc27 View commit details
    Browse the repository at this point in the history

  3. quickly fix failing TestProposerPriorityDoesNotGetResetToZero: 

     - divide by Ceil((maxPriority - minPriority) / 2*totalVotingPower)
    @liamsi
    liamsi committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    f95f76e View commit details
    Browse the repository at this point in the history

  4. fix typo: rename getValWitMostPriority -> getValWithMostPriority

    @liamsi
    liamsi committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    3b54a2c View commit details
    Browse the repository at this point in the history

  5. test proposer frequencies

    @ebuchman
    ebuchman committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    c1cb28e View commit details
    Browse the repository at this point in the history

  6. return absolute value for diff. keep testing

    @ebuchman
    ebuchman committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    4d04461 View commit details
    Browse the repository at this point in the history

  7. use for loop for div

    @ebuchman
    ebuchman committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    2ad9454 View commit details
    Browse the repository at this point in the history

  8. cleanup, more tests

    @ebuchman
    ebuchman committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    f86d5d9 View commit details
    Browse the repository at this point in the history

  9. spellcheck

    @ebuchman
    ebuchman committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    e44904b View commit details
    Browse the repository at this point in the history

  10. Merge pull request #3155 from tendermint/bucky/test-proposer-priority 

    test proposer frequencies
    @ebuchman
    ebuchman committed Jan 18, 2019
    Configuration menu
    Copy the full SHA
    47c0a17 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2019

  1. get rid of using floats: manually ceil where necessary

    @liamsi
    liamsi committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    a8ff373 View commit details
    Browse the repository at this point in the history

  2. Remove float, simplify, fix tests to match chris's proof (#3157)

    @jaekwon @ebuchman
    jaekwon authored and ebuchman committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    cfc0073 View commit details
    Browse the repository at this point in the history