Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json2wal #3147

Merged
merged 5 commits into from
Jan 18, 2019
Merged

Json2wal #3147

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
18ec763
Merge pull request #1 from tendermint/develop
bradyjoestar Jan 18, 2019
416876c
change the size of json2wal reader
swbsin Jan 18, 2019
c2fd291
gofmt
swbsin Jan 18, 2019
433e498
add comment and update the input params
swbsin Jan 18, 2019
7d4ccdd
Update scripts/json2wal/main.go
melekes Jan 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/json2wal/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func main() {
}
defer walFile.Close()

br := bufio.NewReader(f)
br := bufio.NewReaderSize(f, 70000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a comment here explaining why this was necessary. Will help anyone who looks at it in the future :)

Would be even better if we could make it directly a function of the relevant variable - maybe 2 * types.BlockPartSizeBytes for safe keeping :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I should have done it. :)

dec := cs.NewWALEncoder(walFile)

for {
Expand Down