Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for duplicate evidence #3286

Merged
merged 2 commits into from
Feb 8, 2019
Merged

Fixes for duplicate evidence #3286

merged 2 commits into from
Feb 8, 2019

Commits on Feb 8, 2019

  1. Sec/bucky/35 commit duplicate evidence (#36) 

    Don't add committed evidence to evpool
    @ebuchman
    ebuchman committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    90ba639 View commit details
    Browse the repository at this point in the history

  2. Reject blocks with committed evidence (#37) 

    * evidence: NewEvidencePool takes evidenceDB

* evidence: failing TestStoreCommitDuplicate

tendermint/security#35

* GetEvidence -> GetEvidenceInfo

* fix TestStoreCommitDuplicate

* comment in VerifyEvidence

* add check if evidence was already seen
 - modify EventPool interface (EventStore is not known in ApplyBlock):
   - add IsCommitted method to iface
 - add test

* update changelog

* fix TestStoreMark:
 - priority in evidence info gets reset to zero after evidence gets committed

* review comments: simplify EvidencePool.IsCommitted
 - delete obsolete EvidenceStore.IsCommitted

* add simple test for IsCommitted

* update changelog: this is actually breaking (PR number still missing)

* fix TestStoreMark:
 - priority in evidence info gets reset to zero after evidence gets
 committed

* review suggestion: simplify return
    @liamsi @ebuchman
    liamsi authored and ebuchman committed Feb 8, 2019
    Configuration menu
    Copy the full SHA
    87bdc42 View commit details
    Browse the repository at this point in the history