Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: improve ResetTestRootWithChainID() concurrency safety #3291

Merged
merged 18 commits into from
Feb 18, 2019
Merged

R4R: improve ResetTestRootWithChainID() concurrency safety #3291

merged 18 commits into from
Feb 18, 2019

Commits on Feb 13, 2019

  1. improve ResetTestRootWithChainID() concurrency safety 

    Rely on ioutil.TempDir() to create test root directories and ensure
multiple same-chain id test cases can run in parallel.
    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    04c081e View commit details
    Browse the repository at this point in the history

  2. Update config/toml.go 

    Co-Authored-By: alessio <quadrispro@ubuntu.com>
    @liamsi @alessio
    2 people authored and Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    68d1c10 View commit details
    Browse the repository at this point in the history

  3. clean up test directories after completion 

    Closes: #1034
    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    46439db View commit details
    Browse the repository at this point in the history

  4. Remove redundant EnsureDir call

    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    132fd66 View commit details
    Browse the repository at this point in the history

  5. s/PanicSafety()/panic()/s

    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    ab84f0b View commit details
    Browse the repository at this point in the history

  6. Put create dir functionality back in ResetTestRootWithChainID

    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    399bb0d View commit details
    Browse the repository at this point in the history

  7. Place test directories in OS's tempdir 

    In modern UNIX and UNIX-like systems /tmp is very often
mounted as tmpfs. This might speed test execution a bit.
    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    b74e15d View commit details
    Browse the repository at this point in the history

  8. Set 0700 to a const

    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    b77e5f5 View commit details
    Browse the repository at this point in the history

  9. rootsDirs -> configRootDirs

    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    6242b58 View commit details
    Browse the repository at this point in the history

  10. Don't double remove directories

    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    d356778 View commit details
    Browse the repository at this point in the history

  11. Avoid global variables

    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    cffa606 View commit details
    Browse the repository at this point in the history

  12. Fix consensus tests

    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    e5404a6 View commit details
    Browse the repository at this point in the history

  13. Reduce defer stack

    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    2b6386c View commit details
    Browse the repository at this point in the history

  14. Address review comments

    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    6b1bdaf View commit details
    Browse the repository at this point in the history

  15. Try to fix tests

    Alessio Treglia committed Feb 13, 2019
    Configuration menu
    Copy the full SHA
    f46e59b View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2019

  1. Update CHANGELOG_PENDING.md 

    Co-Authored-By: alessio <quadrispro@ubuntu.com>
    @melekes @alessio
    melekes and alessio committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    cea447b View commit details
    Browse the repository at this point in the history

  2. Update consensus/common_test.go 

    Co-Authored-By: alessio <quadrispro@ubuntu.com>
    @melekes @alessio
    melekes and alessio committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    3e7eee5 View commit details
    Browse the repository at this point in the history

  3. Update consensus/common_test.go 

    Co-Authored-By: alessio <quadrispro@ubuntu.com>
    @melekes @alessio
    melekes and alessio committed Feb 16, 2019
    Configuration menu
    Copy the full SHA
    09d270d View commit details
    Browse the repository at this point in the history