Fix tests #330
Fix tests #330
Conversation
ebuchman
commented
Dec 8, 2016
ebuchman
commented
- use ApplyBlock in the blockchain
- set crazy high timeout_propose to accommodate some tests (eventually they should be made robust to round changes).
- copy returned bit arrays in voteset and commit
- clean up p2p test scripts
- fix grpc broadcast test script
|
Did you say don't copy on the commit.BitArray() ? |
| @@ -367,3 +370,18 @@ func getSwitchIndex(switches []*p2p.Switch, peer *p2p.Peer) int { | |||
| panic("didnt find peer in switches") | |||
| return -1 | |||
| } | |||
|
|
|||
| // so we dont violate synchrony assumptions | |||
There was a problem hiding this comment.
Why don't we just modify this in the config/tendermint_test/config.go file?
There was a problem hiding this comment.
I would think that copying the test config every time is sufficient. Why are we also resetting it?
There was a problem hiding this comment.
because in state_test.go we do proposal skipping, where we need it to be small
There was a problem hiding this comment.
Can you point me to where in state_test.go? Something feels wrong about this. Like, maybe this is applying duct-tape on top that increases complexity.
There was a problem hiding this comment.
|
|
||
| ############################################################### | ||
| # for each peer: | ||
| # kill peer |
There was a problem hiding this comment.
It says kill peer here, and the name is restart_peer.sh, but I don't see any logic for killing peers in this file. Misnomer? Need refactor?
There was a problem hiding this comment.
yep the kill happens in fast_sync/test.sh. will update comment
There was a problem hiding this comment.
actually I'll do a little refactoring here
Current coverage is 49.97% (diff: 33.33%)
|
ebuchman
force-pushed
the
fix_tests
branch
2 times, most recently
from
c344e8e
to
9934414
Compare
| @@ -367,3 +370,18 @@ func getSwitchIndex(switches []*p2p.Switch, peer *p2p.Peer) int { | |||
| panic("didnt find peer in switches") | |||
| return -1 | |||
| } | |||
|
|
|||
| // so we dont violate synchrony assumptions | |||
There was a problem hiding this comment.
Can you point me to where in state_test.go? Something feels wrong about this. Like, maybe this is applying duct-tape on top that increases complexity.
…ndermint#330) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.13.1 to 1.14.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.13.1...v1.14.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
