p2p: (seed mode) limit the number of attempts to connect to a peer #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3532 by storing a number of attempts we've tried to connect in-memory and removing the address from addrbook when number of attempts > 16
golangcibot
reviewed
Apr 17, 2019
liamsi
reviewed
Apr 17, 2019
| markAddrInBookBasedOnErr(addr, r.book, err) | ||
| if _, ok := err.(p2p.ErrSwitchAuthenticationFailure); ok { | ||
| switch err.(type) { | ||
| case p2p.ErrSwitchAuthenticationFailure: |
There was a problem hiding this comment.
Not directly related to this PR but can we include a test for this path too?
liamsi
reviewed
Apr 17, 2019
liamsi
reviewed
Apr 17, 2019
liamsi
approved these changes
Apr 17, 2019
liamsi
reviewed
Apr 17, 2019
Co-Authored-By: melekes <anton.kalyaev@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #3573 +/- ##
===========================================
+ Coverage 64.01% 64.15% +0.13%
===========================================
Files 213 213
Lines 17381 17354 -27
===========================================
+ Hits 11127 11134 +7
+ Misses 5323 5297 -26
+ Partials 931 923 -8
|
ebuchman
reviewed
Apr 20, 2019
| err := r.dialPeer(addr) | ||
| if err != nil { | ||
| switch err.(type) { | ||
| case errMaxAttemptsToDial: |
There was a problem hiding this comment.
we can put multiple cases on the same line if the handling is the same:
case errMaxAttemptsToDial, errTooEarlyToDial:
Also, why not move all this into the dialPeer method?
There was a problem hiding this comment.
I needed this method to indicate whenever dialing was successful or not. I can refactor it to return (success bool) and move logging into the method itself (if needed)
brapse
pushed a commit
to brapse/tendermint
that referenced
this pull request
Jun 5, 2019
…endermint#3573) * use dialPeer function in a seed mode Fixes tendermint#3532 by storing a number of attempts we've tried to connect in-memory and removing the address from addrbook when number of attempts > 16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3532