tm-monitor Makefile updated #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- build docker needs go111module on - switch to golang:1.12 to have git available Signed-off-by: Karoly Albert Szabo <szabo.karoly.a@gmail.com>
melekes
reviewed
Jul 12, 2019
| @@ -36,7 +36,7 @@ dist: build-all | |||
|
|
|||
| build-docker: | |||
| rm -f ./tm-monitor | |||
| docker run -it --rm -v "$(PWD)/../../:/go/src/github.com/tendermint/tendermint" -w "/go/src/github.com/tendermint/tendermint/tools/tm-monitor" -e "CGO_ENABLED=0" golang:alpine go build -ldflags "-s -w" -o tm-monitor | |||
| docker run -it --rm -v "$(PWD)/../../:/go/src/github.com/tendermint/tendermint" -w "/go/src/github.com/tendermint/tendermint/tools/tm-monitor" -e "GO111MODULE=on" -e "CGO_ENABLED=0" golang:1.12 go build -ldflags "-s -w" -o tm-monitor | |||
There was a problem hiding this comment.
why not use golang latest image?
There was a problem hiding this comment.
Mainly precaution, if a new latest comes out and is slightly incompatible, we're safe at this hash/tag.
EDIT:
It's a thing I inherited from other languages, maybe go is less affected.
Codecov Report
@@ Coverage Diff @@
## master #3790 +/- ##
==========================================
- Coverage 64.34% 64.21% -0.14%
==========================================
Files 214 214
Lines 18010 18010
==========================================
- Hits 11589 11565 -24
- Misses 5449 5466 +17
- Partials 972 979 +7
|
melekes
approved these changes
Jul 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile
build-dockertarget updated to usego mod:golang:alpinetogolang:1.12to have git