linters: enable stylecheck #4153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
commented
Nov 16, 2019
p2p/conn/secret_connection.go
Outdated
| var _, err1 = cdc.MarshalBinaryLengthPrefixedWriter(conn, locEphPub) | ||
| if err1 != nil { | ||
| return nil, err1, true // abort | ||
| return nil, false, err1 // abort |
There was a problem hiding this comment.
!!!!!!!!!!!!!!!!!!!
There was a problem hiding this comment.
TODO: create an issue because tests weren't failing
melekes
added
T:breaking
Codecov Report
@@ Coverage Diff @@
## master #4153 +/- ##
==========================================
+ Coverage 66.68% 66.69% +0.01%
==========================================
Files 247 247
Lines 21221 21221
==========================================
+ Hits 14151 14154 +3
+ Misses 6010 6008 -2
+ Partials 1060 1059 -1
|
ebuchman
reviewed
Nov 21, 2019
| @@ -45,6 +45,7 @@ program](https://hackerone.com/tendermint). | |||
| - Go API | |||
| - [libs/pubsub] [\#4070](https://github.com/tendermint/tendermint/pull/4070) `Query#(Matches|Conditions)` returns an error. | |||
| - [rpc/client] \#3471 `Validators` now requires two more args: `page` and `perPage` | |||
| - [libs/common] \#3262 Make error the last parameter of `Task` (@PSalant726) | |||
There was a problem hiding this comment.
also cryptoAmino rename.
Also I thought I saw some XYZError get renamed to ErrXYZ but I can't find it now and not sure it was even in a package covered by our versioning
There was a problem hiding this comment.
also cryptoAmino rename.
how's this breaking? I am not even sure it's worth mentioning in the changelog
There was a problem hiding this comment.
isn't it a change in package name?
There was a problem hiding this comment.
imo it's only breaking if you rename the folder
Client code uses the package path when importing the package. By convention, the last element of the package path is the package name
melekes
added a commit
that referenced
this pull request
Nov 21, 2019
melekes
added a commit
that referenced
this pull request
Nov 22, 2019
melekes
added a commit
that referenced
this pull request
Nov 22, 2019
melekes
added a commit
that referenced
this pull request
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3961
This PR repairs linter errors seen when running the following command:
golangci-lint run --no-config --disable-all=true --enable=stylecheck
Contributes to #3262
Updated all relevant documentation in docsUpdated all code comments where relevantWrote tests