Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: branch for fix of ci #4266

Merged
merged 3 commits into from
Dec 20, 2019
Merged

test: branch for fix of ci #4266

merged 3 commits into from
Dec 20, 2019

Conversation

tac0turtle
Copy link
Contributor

  • testing replacing syscall with os.FindProces

Signed-off-by: Marko Baricevic marbar3778@yahoo.com

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@tac0turtle
test:
0d41e80 
- testing replacing syscall with os.FindProces

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle
Merge branch 'master' into marko/test_os_find
3d445a6
@codecov-io
Copy link

codecov-io commented Dec 19, 2019 •
edited

Codecov Report

Merging #4266 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4266      +/-   ##
==========================================
- Coverage   65.61%   65.59%   -0.02%     
==========================================
  Files         225      225              
  Lines       19406    19406              
==========================================
- Hits        12733    12730       -3     
- Misses       5694     5698       +4     
+ Partials      979      978       -1
Impacted Files Coverage Δ
privval/signer_endpoint.go 75.67% <0%> (-5.41%) ⬇️
privval/signer_listener_endpoint.go 86.95% <0%> (-2.18%) ⬇️
consensus/state.go 77.66% <0%> (-1.35%) ⬇️
consensus/replay.go 71.76% <0%> (-0.79%) ⬇️
p2p/conn/connection.go 80.71% <0%> (-0.26%) ⬇️
p2p/pex/pex_reactor.go 82.48% <0%> (ø) ⬆️
blockchain/v0/pool.go 79.16% <0%> (+0.32%) ⬆️
consensus/reactor.go 78.77% <0%> (+1.03%) ⬆️
privval/signer_server.go 95.65% <0%> (+4.34%) ⬆️
blockchain/v2/reactor.go 63.15% <0%> (+12.28%) ⬆️

@tac0turtle tac0turtle marked this pull request as ready for review December 19, 2019 18:45
melekes
melekes reviewed Dec 20, 2019
View reviewed changes
cmd/tendermint/commands/debug/kill.go Outdated Show resolved Hide resolved
cmd/tendermint/commands/debug/kill.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle merged commit a183809 into master Dec 20, 2019
@tac0turtle tac0turtle deleted the marko/test_os_find branch December 20, 2019 10:42
melekes added a commit that referenced this pull request Dec 21, 2019
@melekes
cmd/debug: execute p.Signal when p is not nil
207e8c5 
#4266 (comment)
@melekes melekes mentioned this pull request Dec 21, 2019
Merged
5 tasks
melekes added a commit that referenced this pull request Dec 21, 2019
@melekes
cmd/debug: execute p.Signal when p is not nil
bcda84c 
#4266 (comment)
melekes added a commit that referenced this pull request Dec 22, 2019
@melekes
cmd/debug: execute p.Signal only when p is not nil (#4271)
7d7b47a 
* cmd/debug: execute p.Signal when p is not nil

#4266 (comment)

* replace else with else if
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio alessio alessio left review comments

@melekes melekes melekes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@tessr tessr Awaiting requested review from tessr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tac0turtle @codecov-io @alessio @melekes