rpc: create buffered subscriptions on /subscribe #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffer size: 100 Closes #3935
erikgrinaker
reviewed
Mar 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #4521 +/- ##
==========================================
+ Coverage 65.22% 65.29% +0.07%
==========================================
Files 229 229
Lines 20269 20273 +4
==========================================
+ Hits 13220 13238 +18
+ Misses 5994 5980 -14
Partials 1055 1055
|
tessr
approved these changes
Mar 5, 2020
| @@ -24,6 +24,7 @@ Friendly reminder, we have a [bug bounty program](https://hackerone.com/tendermi | |||
|
|
|||
| ### BUG FIXES: | |||
|
|
|||
| - [rpc] \#3935 Create buffered subscriptions on `/subscribe` (@melekes) | |||
There was a problem hiding this comment.
nit, but do you want to make this a link like the other items in this list?
There was a problem hiding this comment.
technically this is the correct way according to the contributing.md and then there is a script to add all the links prior to release. People have been putting links recently, I guess we should decide on one way or the other?
https://github.com/tendermint/tendermint/blob/master/CONTRIBUTING.md#changelog
There was a problem hiding this comment.
yeah, there's a script for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buffer size: 100
Closes #3935
For contributor use:
Wrote teststested manuallydocs/) and code commentsFiles changedin the Github PR explorer