Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc/client: split out client packages #4628

Merged
merged 5 commits into from
Apr 2, 2020
Merged

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Apr 2, 2020

Fixes #4626:

  • Split rpc/client implementations into rpc/client/http and rpc/client/local, and rename constructors.
  • Split lite2 tests into separate lite_test package.
    • Embed SignStatusClient in http.http struct, so tests can convert it.

For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@codecov-io
Copy link

Codecov Report

Merging #4628 into master will increase coverage by 0.89%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master    #4628      +/-   ##
==========================================
+ Coverage   65.43%   66.32%   +0.89%     
==========================================
  Files         229      220       -9     
  Lines       20444    19608     -836     
==========================================
- Hits        13377    13005     -372     
+ Misses       6004     5587     -417     
+ Partials     1063     1016      -47     
Impacted Files Coverage Δ
cmd/tendermint/commands/lite.go 24.65% <0.00%> (ø)
lite2/provider/http/http.go 28.57% <57.14%> (ø)
lite/client/provider.go 38.09% <100.00%> (ø)
p2p/pex/errors.go 11.11% <0.00%> (-11.12%) ⬇️
p2p/metrics.go 95.23% <0.00%> (-4.77%) ⬇️
p2p/pex/pex_reactor.go 82.58% <0.00%> (-1.69%) ⬇️
consensus/replay.go 71.76% <0.00%> (-0.79%) ⬇️
p2p/pex/addrbook.go 70.16% <0.00%> (-0.47%) ⬇️
rpc/lib/server/http_uri_handler.go
rpc/core/types/codec.go
... and 21 more

Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@erikgrinaker erikgrinaker added the S:automerge Automatically merge PR when requirements pass label Apr 2, 2020
@mergify mergify bot merged commit fdf9c7a into master Apr 2, 2020
@mergify mergify bot deleted the erik/rpc-client-reorg branch April 2, 2020 13:25
@@ -14,6 +14,7 @@ Friendly reminder, we have a [bug bounty program](https://hackerone.com/tendermi

- Go API

- [rpc/client] [\#4628](https://github.com/tendermint/tendermint/pull/4628) Split out HTTP and local clients into `http` and `local` packages (@erikgrinaker).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add a sentence or two to upgrading.md about this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:automerge Automatically merge PR when requirements pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

light: node/RPC import cycle
4 participants