-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc/client: split out client packages #4628
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4628 +/- ##
==========================================
+ Coverage 65.43% 66.32% +0.89%
==========================================
Files 229 220 -9
Lines 20444 19608 -836
==========================================
- Hits 13377 13005 -372
+ Misses 6004 5587 -417
+ Partials 1063 1016 -47
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -14,6 +14,7 @@ Friendly reminder, we have a [bug bounty program](https://hackerone.com/tendermi | |||
|
|||
- Go API | |||
|
|||
- [rpc/client] [\#4628](https://github.com/tendermint/tendermint/pull/4628) Split out HTTP and local clients into `http` and `local` packages (@erikgrinaker). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should add a sentence or two to upgrading.md about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call
Fixes #4626:
rpc/client
implementations intorpc/client/http
andrpc/client/local
, and rename constructors.lite2
tests into separatelite_test
package.SignStatusClient
inhttp.http
struct, so tests can convert it.For contributor use:
docs/
) and code commentsFiles changed
in the Github PR explorer