Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs: remove bech32 #4831

Merged
merged 3 commits into from May 12, 2020
Merged

libs: remove bech32 #4831

merged 3 commits into from May 12, 2020

Conversation

tac0turtle
Copy link
Contributor

@tac0turtle tac0turtle commented May 12, 2020 •
edited

Description

bech32 is only used in the sdk. I moved Bech32 to the sdk and we can remove it here. Don't think this needs to go into a minor release

Closes: #XXX

@tac0turtle tac0turtle added the T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label May 12, 2020
@tac0turtle tac0turtle self-assigned this May 12, 2020
@auto-comment
Copy link

auto-comment bot commented May 12, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@tac0turtle tac0turtle marked this pull request as ready for review May 12, 2020 17:07
@tac0turtle tac0turtle added the S:automerge Automatically merge PR when requirements pass label May 12, 2020
@mergify mergify bot merged commit 01e032d into master May 12, 2020
@mergify mergify bot deleted the marko/remove_bech32 branch May 12, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

@tessr tessr Awaiting requested review from tessr

Assignees

@tac0turtle tac0turtle

Labels
S:automerge Automatically merge PR when requirements pass T:code-hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tac0turtle @melekes